This repository was archived by the owner on Jan 18, 2023. It is now read-only.
Implement new deployment script #391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felix2feng
approved these changes
Feb 21, 2019
Contributor
felix2feng
left a comment
felix2feng
left a comment
There was a problem hiding this comment.
Awesome - this is good
| DEPLOYMENT_PRIVATE_KEY="0xA..." | ||
| // The network name set here will use constants from `network-constants.ts` | ||
| DEPLOYMENT_NETWORK_NAME="development" |
Contributor
There was a problem hiding this comment.
Let's detail which networks you can deploy to. kovan, main etc.
| DEPLOYMENT_NETWORK_NAME="development" | ||
| // Network id will indicate which chain to run on (testnet, mainnet etc) | ||
| DEPLOYMENT_NETWORK_ID=50; |
Contributor
There was a problem hiding this comment.
Which network corresponds to what? Would be helpful
.gitignore
Outdated
| blockchain/ | ||
|
|
||
| # Ouputs | ||
| outputs.ts |
Contributor
There was a problem hiding this comment.
Do you mean deployments/outputs.ts?
Contributor
Author
There was a problem hiding this comment.
Not sure if the path makes a difference but added it for granularity's sake
Pull Request Test Coverage Report for Build 4324
💛 - Coveralls |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.