Update workflows #2
Conversation
|
Warning Rate limit exceeded@Shane32 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 7 minutes and 56 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe GitHub Actions workflows for building, testing, and publishing .NET artifacts were refactored. The custom inline steps in the workflow files were removed and replaced by jobs that invoke external reusable workflows. The build workflow was deleted, and the solution file was updated to reflect the removal of the build workflow. Changes
Sequence Diagram(s)sequenceDiagram
participant GitHub Actions
participant Shared Workflows
GitHub Actions->>Shared Workflows: Trigger build-check (tests.yml) with dotnet_folder and coveralls inputs
Shared Workflows-->>GitHub Actions: Run build, test, coverage, and formatting checks
GitHub Actions->>Shared Workflows: Trigger publish (publish.yml) with dotnet_folder input
Shared Workflows-->>GitHub Actions: Run build, pack, and publish steps
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (2)
.github/workflows/publish.yml (1)
4-9: Watch for duplicate workflow executions on PR branches
Because bothpushandreleaseremain enabled and thepushtrigger includesmain/master/develop, any PR coming from a branch inside the same repo (e.g.develop) will fire twice: once forpushand again forpull_request(in other workflows). Consider addingif: github.event_name != 'pull_request'or narrowing thepushscope to avoid redundant CI minutes..github/workflows/tests.yml (1)
5-9: Potential double builds on internal branches
With bothpull_requestandpushtriggers includingmain|master|develop, PRs originating from those branches cause two identical runs. If that is unintentional, limit one trigger or gate the job withif: ${{ github.event_name == 'pull_request' }}.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.github/workflows/build.yml(0 hunks).github/workflows/publish.yml(1 hunks).github/workflows/tests.yml(1 hunks)Shane32.TestHelpers.sln(1 hunks)
💤 Files with no reviewable changes (1)
- .github/workflows/build.yml
🔇 Additional comments (1)
Shane32.TestHelpers.sln (1)
11-13: Removal ofbuild.ymlreference looks correct
The deleted workflow entry was stale after the workflow was dropped, and the re-ordering ofREADME.mdis cosmetic only. No action required.
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
.github/workflows/publish.yml (1)
14-18: Pin reusable workflow by commit SHAThe reference
Shane32/SharedWorkflows/.github/workflows/publish-nuget.yml@fix_coverallspoints to a branch, so upstream changes will silently alter your release process. For deterministic builds and supply-chain safety, pin this to a specific commit SHA (and let Dependabot update it).- uses: Shane32/SharedWorkflows/.github/workflows/publish-nuget.yml@fix_coveralls + # Pinned for reproducibility – update via Dependabot + uses: Shane32/SharedWorkflows/.github/workflows/publish-nuget.yml@<commit-sha>
Coverage Report
|
Summary by CodeRabbit