Gulp deploy-azure-storage uploads 0 files with SPFx 1.12

[coreyroth]

Category

• Bug

Describe the bug

I have updated my projects from SPFx 1.11 to 1.12 and I noticed that no files were getting deployed to my CDN. After investigating my pipeline logs, I saw that no files were being uploaded. I then investigated further and I saw the same behavior. I did a gulp clean which removed my temp/deploy folder. Then when I run gulp bundle --ship followed by gulp deploy-azure-storage no files are uploaded because no files are present in the temp/deploy folder.

Steps to reproduce

Therefore, I decided to start over from scratch with a new project using the CDN Getting Started. I created a brand new CDN following all of the instructions and I am seeing the same issue. I've tried it with both web parts and application customizer projects.

Repo

Here's some example output:

Build target: DEBUG  
[16:23:27] Using gulpfile ~/Projects/SPFx/SPFx1.12WebPart/gulpfile.js  
[16:23:27] Starting 'deploy-azure-storage'...  
[16:23:27] Starting gulp  
[16:23:27] Starting subtask 'configure-sp-build-rig'...  
[16:23:27] Finished subtask 'configure-sp-build-rig' after 3.06 ms  
[16:23:27] Starting subtask 'deploy-azure-storage'...  
[16:23:27] [deploy-azure-storage] Uploading files '**/*.*' from directory './temp/deploy/' to Azure  
[16:23:27] [deploy-azure-storage] Created container: azurehosted-webpart  
[16:23:27] [deploy-azure-storage] Uploading 0 files to Azure...  
[16:23:27] [deploy-azure-storage] Upload complete!  
[16:23:27] [deploy-azure-storage] Access your files at: https://spfxcdntest.blob.core.windows.net/azurehosted-webpart  
[16:23:27] Finished subtask 'deploy-azure-storage' after 364 ms

Expected behavior

File to be created in temp/deploy, files to be uploaded to Azure storage account.

Environment details (development & target environment)

• Your Developer Environment: Mac OS 11.2.1
• Target Environment: SharePoint Online
• Framework: Node 12, Gulp 4
• Browser(s): Edge v90
• Tooling: VS Code | SPFx v1.12.0

Additional context

This worked for my project in SPFx 1.11 without issue. I have went back and double checked and I don't think I have missed anything. There simply aren't any files in temp/deploy, the path specified in copy-assets.json.

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

[coreyroth]

I did some additional testing on this today. This really isn't an issue with the deploy-azure-storage task as it is actually an issue with gulp bundle --ship not copying the files to temp/deploy. I tried first updating copy-assets.json to point to release/assets but it still looked in temp/deploy, but the deploy-azure-storage task still looked in temp/deploy. I then simply ran "cp release/assets/* temp/deploy" and then ran deploy-azure-storage again and it worked as expected. It appears the copy assets subtask of gulp bundle is not executing.

[KevinTCoughlin]

Thanks @coreyroth. I believe the problem was a hard-coded path assuming assets were still written to temp/deploy as you pointed out.

public async executeTask(): Promise<void> {
  if (!this.taskConfig.workingDir) {
    this.taskConfig.workingDir = this.buildConfig.distFolder;
  }
  ...
}

We are validating a patch release candidate with the fix.

[coreyroth]

Thanks @KevinTCoughlin. Make sure there aren’t two issues. One for the hard coded path in deploy-azure-storage and one to ensure files are copied into temp/deploy (or the configured path in the JSON).

[VesaJuvonen]

This issue is intended to be part of the upcoming 1.12.1 patch release. Currently we recommend to keep on using 1.11 until further notice. We do apologize the inconvenience.