Skip to content

Conversation

ReidCarlberg
Copy link
Contributor

Category

  • Content fix
  • New article

he issue list as it will (1) link the PR to the issue & (2) automatically close the issue when this PR is merged in.*

What's in this Pull Request?

Correct example for CSP

The -OwningApplicationId is a UUID format, and in the example it was just 8 random characters, which wasn't clear.
Syntax for an array of hosts was wrong.
Copy link
Contributor

Learn Build status updates of commit e260eac:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/embedded/development/declarative-agent/spe-da-adv.md ⚠️Warning View Details

docs/embedded/development/declarative-agent/spe-da-adv.md

  • Line 88, Column 155: [Warning: bookmark-not-found - See documentation] Cannot find bookmark '#rag--retrieval-augmented-generation-' in 'embedded/development/declarative-agent/spe-da-adv.md'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@dluces dluces requested a review from andrewconnell May 15, 2025 02:38
@andrewconnell andrewconnell self-assigned this May 15, 2025
@andrewconnell andrewconnell added the pr:in-review Actively reviewing pull request label May 15, 2025
Copy link
Contributor

Learn Build status updates of commit d7346f6:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/embedded/development/declarative-agent/spe-da-adv.md ⚠️Warning View Details

docs/embedded/development/declarative-agent/spe-da-adv.md

  • Line 88, Column 159: [Warning: bookmark-not-found - See documentation] Cannot find bookmark '#rag--retrieval-augmented-generation-' in 'embedded/development/declarative-agent/spe-da-adv.md'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Collaborator

@andrewconnell andrewconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This page somehow got passed some QC checks previously... some things need to get fixed, like paragraphs with incomplete statements (line 163) or punctuations (lines 114 & 118)...

Please correct these. Also suggest running Acrolinx (available to MSFT internals) on pages before submitting PRs as it finds a lot of issues on it's own.

@andrewconnell andrewconnell added Needs: Author Feedback Awaiting response from the original poster of the issue. Marked as stale if no activity for 7 days. pr:do-not-merge Pull request not ready to be merged and removed pr:in-review Actively reviewing pull request labels May 15, 2025
@andrewconnell
Copy link
Collaborator

@ReidCarlberg action required on your part... we can't merge content for people who haven't completed the CLA. See the steps above for instructions on what to do.

@cindylay FYI

Copy link
Contributor

Learn Build status updates of commit 91883df:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details

  • [Error: CannotMergeCommit] Cannot merge commit 91883df28714768683d259392540525e813fdbcb in branch main of repository https://github.com/ReidCarlberg/sp-dev-docs into branch main (commit efe2fda3563f58d977d96657872db8e31c051c13). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@andrewconnell
Copy link
Collaborator

Multiple upstream comments in conflicting PRs put this PR in direct conflict with the main branch. Feel free to correct & reopen, but it seems this is no longer relevant/necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Author Feedback Awaiting response from the original poster of the issue. Marked as stale if no activity for 7 days. pr:do-not-merge Pull request not ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants