-
Notifications
You must be signed in to change notification settings - Fork 1k
CSP example fix #10250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSP example fix #10250
Conversation
The -OwningApplicationId is a UUID format, and in the example it was just 8 random characters, which wasn't clear.
Syntax for an array of hosts was wrong.
Update spe-da-adv.md
Update spe-da-adv.md
Learn Build status updates of commit e260eac:
|
File | Status | Preview URL | Details |
---|---|---|---|
docs/embedded/development/declarative-agent/spe-da-adv.md | View | Details |
docs/embedded/development/declarative-agent/spe-da-adv.md
- Line 88, Column 155: [Warning: bookmark-not-found - See documentation]
Cannot find bookmark '#rag--retrieval-augmented-generation-' in 'embedded/development/declarative-agent/spe-da-adv.md'.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
Learn Build status updates of commit d7346f6:
|
File | Status | Preview URL | Details |
---|---|---|---|
docs/embedded/development/declarative-agent/spe-da-adv.md | View | Details |
docs/embedded/development/declarative-agent/spe-da-adv.md
- Line 88, Column 159: [Warning: bookmark-not-found - See documentation]
Cannot find bookmark '#rag--retrieval-augmented-generation-' in 'embedded/development/declarative-agent/spe-da-adv.md'.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This page somehow got passed some QC checks previously... some things need to get fixed, like paragraphs with incomplete statements (line 163) or punctuations (lines 114 & 118)...
Please correct these. Also suggest running Acrolinx (available to MSFT internals) on pages before submitting PRs as it finds a lot of issues on it's own.
@ReidCarlberg action required on your part... we can't merge content for people who haven't completed the CLA. See the steps above for instructions on what to do. @cindylay FYI |
Learn Build status updates of commit 91883df: ❌ Validation status: errorsPlease follow instructions here which may help to resolve issue.
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
Multiple upstream comments in conflicting PRs put this PR in direct conflict with the main branch. Feel free to correct & reopen, but it seems this is no longer relevant/necessary. |
Category
he issue list as it will (1) link the PR to the issue & (2) automatically close the issue when this PR is merged in.*
What's in this Pull Request?
Correct example for CSP