Skip to content

Customize SharePoint page approvals to meet your needs #5742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 18, 2020

Conversation

jackwi-alt
Copy link
Contributor

@jackwi-alt jackwi-alt commented May 14, 2020

Category

[x] New article

What's in this Pull Request?

A new article that will go under the Guidance section for Power Automate. The article is about customizing SharePoint page approvals.

@jackwi-alt jackwi-alt requested a review from chakkaradeep May 14, 2020 22:04
@andrewconnell
Copy link
Collaborator

andrewconnell commented May 15, 2020

Where would this go.... there's no inclusion in the TOC or cross-linked from another page. In addition, it's the "policy" of this repo to not accept PR's that don't complete the PR template that's added when creating a PR. Please correct and resubmit. Thanks!

@chakkaradeep
Copy link
Contributor

chakkaradeep commented May 15, 2020

@andrewconnell This is a PR for product documentation managed by the product team. While this PR may not have the right inclusions in the details, @jackwi-alt and I are in contact and working together, and @jackwi-alt has added me as the reviewer to this PR as well.

In the future, it would be better to @ mention the reviewer, ask for more details, than just close the PR as you might not be aware of what is happening behind the scenes within the product team.

Thank you!

@andrewconnell
Copy link
Collaborator

Sorry... I had replied to previous PR's & not received responses. Maybe I misunderstood a recent discussion with @VesaJuvonen, but my understanding was we wouldn't accept PRs without the minimal information.

@VesaJuvonen
Copy link
Contributor

Hi @chakkaradeep and @jackwi-alt - we have requested our MVPs/vendors to require baseline submissions from all people who submit PRs - as if we provide exceptions for Microsoft submissions, we cannot demand higher quality from others in the community. Filling the PR form takes 2 min - so should not be an issue and I'd love that we all would work under the same rules - as we should be the example for the community by showing how to contribute.

Asking few mins more time for filling the PR as requested does not seem that unreasonable for anyone. Makes sense?

@chakkaradeep
Copy link
Contributor

@VesaJuvonen Completely agree, but lets do follow up with PR owners and reviewers than closing the PR. In cases where we lack information, lets ask PR owner/reviewer to add more information.

@andrewconnell
Copy link
Collaborator

@chakkaradeep will do... only reason I started doing it this way is it seemed every time I was leaving a comment on the PR to a MSFT author, no one was responding and it would sit there (this has been going on for months). Closing it was the only way to get their attention & respond. The author of a PR is on the notification chain when someone replies, so an @mention isn't really necessary...

Updated screenshots and TOC for the Power Automate customize page approvals.
@chakkaradeep chakkaradeep merged commit 34f2390 into master May 18, 2020
Copy link
Contributor

@chakkaradeep chakkaradeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and updated TOC and images.

@VesaJuvonen
Copy link
Contributor

Can we address the broken links on this one, before merging live. Thx.

@VesaJuvonen
Copy link
Contributor

Happy to help as needed, just let me know.

@jackwi-alt
Copy link
Contributor Author

Vesa: Precisely, what links are broken?

@VesaJuvonen
Copy link
Contributor

This is from the Build report. Something to fix as these will be reported as part of all builds. Build reports are generated with all merges which then start the docs build process for validating the merged docs. These are also generated for all PRs which is a great way to check the status even before merging.

—-

Please see 3 more validated files in report below.

docs/business-apps/power-automate/guidance/customize-page-approvals.md
Line 15: [Warning] Invalid file link:(/business-apps/power-automate/guidance/handle-news-posts).
Line 17: [Warning] Invalid file link:(
/business-apps/power-automate/guidance/parallel-approvals).
Line 16: [Warning] Invalid file link:(~/business-apps/power-automate/guidance/auto-approve-pages).

@VesaJuvonen
Copy link
Contributor

As we have other pending things to get out, fixed this quickly now. There were few issues on the submission:

  • Unnecessary TOC for the page, which is auto-generated by docs platform
  • TOC contained broken links which did not work
  • One of the four images had broken path in it - fixed now

Provided fixes are at 91ab57d

I'd strongly recommend installing https://marketplace.visualstudio.com/items?itemName=docsmsft.docs-authoring-pack as that provides great check tooling for the doc edits. Reduces possibility of small issues here and there.

For MSFTs or v-accounts - great resource for would be following - https://review.docs.microsoft.com/en-us/help/contribute/contribute-get-started-setup-tools?branch=master

If there's any further questions on the tooling, process, etc. Let me know.

@VesaJuvonen VesaJuvonen deleted the jackwi-alt-customize-page-approvals branch April 29, 2021 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants