-
Notifications
You must be signed in to change notification settings - Fork 1k
Customize SharePoint page approvals to meet your needs #5742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
New article transposed from blog.
Where would this go.... there's no inclusion in the TOC or cross-linked from another page. In addition, it's the "policy" of this repo to not accept PR's that don't complete the PR template that's added when creating a PR. Please correct and resubmit. Thanks! |
@andrewconnell This is a PR for product documentation managed by the product team. While this PR may not have the right inclusions in the details, @jackwi-alt and I are in contact and working together, and @jackwi-alt has added me as the reviewer to this PR as well. In the future, it would be better to @ mention the reviewer, ask for more details, than just close the PR as you might not be aware of what is happening behind the scenes within the product team. Thank you! |
Sorry... I had replied to previous PR's & not received responses. Maybe I misunderstood a recent discussion with @VesaJuvonen, but my understanding was we wouldn't accept PRs without the minimal information. |
Hi @chakkaradeep and @jackwi-alt - we have requested our MVPs/vendors to require baseline submissions from all people who submit PRs - as if we provide exceptions for Microsoft submissions, we cannot demand higher quality from others in the community. Filling the PR form takes 2 min - so should not be an issue and I'd love that we all would work under the same rules - as we should be the example for the community by showing how to contribute. Asking few mins more time for filling the PR as requested does not seem that unreasonable for anyone. Makes sense? |
@VesaJuvonen Completely agree, but lets do follow up with PR owners and reviewers than closing the PR. In cases where we lack information, lets ask PR owner/reviewer to add more information. |
@chakkaradeep will do... only reason I started doing it this way is it seemed every time I was leaving a comment on the PR to a MSFT author, no one was responding and it would sit there (this has been going on for months). Closing it was the only way to get their attention & respond. The author of a PR is on the notification chain when someone replies, so an @mention isn't really necessary... |
Updated screenshots and TOC for the Power Automate customize page approvals.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and updated TOC and images.
Can we address the broken links on this one, before merging live. Thx. |
Happy to help as needed, just let me know. |
Vesa: Precisely, what links are broken? |
This is from the Build report. Something to fix as these will be reported as part of all builds. Build reports are generated with all merges which then start the docs build process for validating the merged docs. These are also generated for all PRs which is a great way to check the status even before merging. —- Please see 3 more validated files in report below. docs/business-apps/power-automate/guidance/customize-page-approvals.md |
As we have other pending things to get out, fixed this quickly now. There were few issues on the submission:
Provided fixes are at 91ab57d I'd strongly recommend installing https://marketplace.visualstudio.com/items?itemName=docsmsft.docs-authoring-pack as that provides great check tooling for the doc edits. Reduces possibility of small issues here and there. For MSFTs or v-accounts - great resource for would be following - https://review.docs.microsoft.com/en-us/help/contribute/contribute-get-started-setup-tools?branch=master If there's any further questions on the tooling, process, etc. Let me know. |
Category
[x] New article
What's in this Pull Request?
A new article that will go under the Guidance section for Power Automate. The article is about customizing SharePoint page approvals.