Skip to content

Focus feature GA documentation #8834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 4, 2023
Merged

Conversation

micwilson911
Copy link
Contributor

Category

  • Content fix
  • New article

What's in this Pull Request?

These changes introduce general documentation on a new focus feature that is being released with the SPFx 1.17 release.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 3b27048:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/spfx/viva/features/focus-feature/FocusFeatureDocumentation.md ⚠️Warning View Details
docs/spfx/viva/features/focus-feature/FocusFeatureTutorial.md ⚠️Warning View Details
docs/spfx/viva/features/focus-feature/img/focusFeatureFirstView.png ✅Succeeded View
docs/spfx/viva/features/focus-feature/img/focusFeatureSecondView.png ✅Succeeded View
docs/spfx/viva/features/focus-feature/img/focusFeatureThirdView.png ✅Succeeded View
docs/spfx/viva/features/focus-feature/img/focusFeatureTutorialACE.png ✅Succeeded View
docs/spfx/viva/features/focus-feature/img/focusFeatureTutorialQuickViewAriaSet.png ✅Succeeded View

docs/spfx/viva/features/focus-feature/FocusFeatureDocumentation.md

  • Line 8, Column 83: [Warning: file-not-found - See documentation] Invalid file link: '../../../../release-1.17.md'.
  • Line 13, Column 75: [Warning: file-not-found - See documentation] Invalid file link: '../../../get-started/build-first-sharepoint-adaptive-card-extension.md'.
  • Line 56, Column 24: [Warning: file-not-found - See documentation] Invalid file link: './MediaUploadTutorial.md'.

docs/spfx/viva/features/focus-feature/FocusFeatureTutorial.md

  • Line 80, Column 1: [Warning: file-not-found - See documentation] Invalid file link: './focusFeatureTutorialACE.png'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod
Copy link
Contributor

@learn-build-service-prod
Copy link
Contributor

@VesaJuvonen VesaJuvonen added the pr:do-not-merge Pull request not ready to be merged label Mar 23, 2023
@andrewconnell andrewconnell self-assigned this Mar 23, 2023
@andrewconnell andrewconnell added pr:in-review Actively reviewing pull request and removed pr:do-not-merge Pull request not ready to be merged labels Mar 23, 2023
updated reference to match msdocs standard for referencing another doc
@learn-build-service-prod
Copy link
Contributor

Copy link
Collaborator

@andrewconnell andrewconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New pages should be run through Acrolynx (internal link) to improve page readability score by improving grammar, reading level, & standardizing (and omitting) word selection.

@andrewconnell
Copy link
Collaborator

@micwilson911 New content for new feature in an upcoming release... needs review & merge by @VesaJuvonen. Docs could be improved with my suggestion in above comment (run docs through Acrolinx).

Also, where will this get referenced from? At this point, this PR doesn't include links to anything or appear in the TOC, so how will someone find it other than googling the term once it's indexed?

@andrewconnell andrewconnell added pr:ready-to-merge Ready to merge PR and removed pr:in-review Actively reviewing pull request labels Mar 23, 2023
@VesaJuvonen VesaJuvonen added pr:do-not-merge Pull request not ready to be merged and removed pr:ready-to-merge Ready to merge PR labels Mar 28, 2023
@VesaJuvonen VesaJuvonen removed the pr:do-not-merge Pull request not ready to be merged label Apr 4, 2023
@VesaJuvonen VesaJuvonen merged commit fe06b36 into main Apr 4, 2023
@VesaJuvonen
Copy link
Contributor

thx @micwilson911 for these - great work. I'll add it to the TOC and get it referenced in the release notes... including Acrolinx execution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants