Replace reflections package with reflections8 #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently I'm able to invoke our codepropertygraph's console via a path that triggers ronmamo/reflections#273. This is very unfortunate and due to the way the artifact is being published I'm unable to downgrade directly in the project I use. Sadly this dependency is propagated very far down the chain and it impossible to untangle it. The fix is in `0.9.13-SNAPSHOT` (not yet released) so suggesting to downgrade until it is officially out. Note: I was going to just downgrade to `0.9.11` but looks like that version is pretty ancient. Instead I followed the same suggestion as in JanusGraph/janusgraph#2029 and replaced `reflections` with `reflections8` until `0.9.13` is released.
hubertp
changed the title
mpollmeier
approved these changes
Sep 20, 2020
Contributor
mpollmeier
left a comment
mpollmeier
left a comment
There was a problem hiding this comment.
cc @fabsx00 the joys of reflection :(
delete-merged-branch
bot
deleted the
hubert/replace-reflections-with-reflections8
branch
hubertp
added a commit
to ShiftLeftSecurity/codepropertygraph
that referenced
this pull request
Sep 21, 2020
Bringing in the change from ShiftLeftSecurity/overflowdb#162
mpollmeier
pushed a commit
to ShiftLeftSecurity/codepropertygraph
that referenced
this pull request
Sep 21, 2020
Bringing in the change from ShiftLeftSecurity/overflowdb#162
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently I'm able to invoke our codepropertygraph's console via a path
that triggers ronmamo/reflections#273.
This is very unfortunate and due to the way the artifact is being
published I'm unable to downgrade directly in the project I use.
Sadly this dependency is propagated very far down the chain and it
impossible to untangle it.
The fix is in
0.9.13-SNAPSHOT(not yet released) so suggesting todowngrade until it is officially out.
Note: I was going to just downgrade to
0.9.11but looks like thatversion is pretty ancient. Instead I followed the same suggestion as in
JanusGraph/janusgraph#2029
and replaced
reflectionswithreflections8until0.9.13isreleased.