Reduce the number of host calls when logging#279
Merged
Conversation
saulecabrera
approved these changes
Mar 13, 2023
Member
I think we should run some benchmarks as part of this change to have a concrete idea of the improvements that we're referring to here. |
Co-authored-by: Saúl Cabrera <saulecabrera@gmail.com>
Collaborator
Author
|
Added a benchmark, I'm seeing a 9% to 17% improvement for 100 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While investigating something related to failures when calling
console.error, I noticed our current implementation is making more host calls than necessary when writing logs. Each call towriteonstreamwill invoke a host call since writes to the stderr stream are not buffered.This change ensures we only make one one host call when invoking
console.errorwhich should improve runtime performance.