Don't raise if no variable found when using context.key? with strict_variables
#2007
+16
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously if you set `strict_variables` to `true` on the context using
`key?('key_name')` would raise a `Liquid::UndefinedVariable` error.
Raising this error makes sense if you're trying to access the variable
directly with something like `context['key_name']` but by using `key?`
you're safely checking if it exists first.
You should be able to enable `strict_variables` and use `key?` in
combination with each other to ensure code safety.
EvilGenius13
approved these changes
Oct 31, 2025
aswamy
approved these changes
Oct 31, 2025
Contributor
aswamy
left a comment
aswamy
left a comment
There was a problem hiding this comment.
Seems like a fair change. I didn't know searching a key like that even threw an error :|
Contributor
Author
It only throws an error if you've set |
graygilmore
commented
Nov 3, 2025
|
|
||
| def key?(key) | ||
| self[key] != nil | ||
| find_variable(key, raise_on_not_found: false) != nil |
Contributor
Author
There was a problem hiding this comment.
This is an opinionated change. Instead of evaluating Expression.parse to look up the tree if we don't find a match we should assume that somebody is passing a simple lookup to key? and check for it directly.
karreiro
approved these changes
Nov 4, 2025
Contributor
karreiro
left a comment
karreiro
left a comment
There was a problem hiding this comment.
Thank you, @graygilmore! This change looks fair me, specially considering find_variable implementation :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if you set
strict_variablestotrueon the context usingkey?('key_name')would raise aLiquid::UndefinedVariableerror. Raising this error makes sense if you're trying to access the variable directly with something likecontext['key_name']but by usingkey?you're safely checking if it exists first.You should be able to enable
strict_variablesand usekey?in combination with each other to ensure code safety.