Skip to content

Commit 3f2cd48

Browse files
Alex Pagesylvhama
authored andcommitted
[Navigation] Adjust :active color for selected items (#3562)
1 parent 84e2fbd commit 3f2cd48

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

UNRELEASED.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@ Use [the changelog guidelines](https://git.io/polaris-changelog-guidelines) to f
1616

1717
### Bug fixes
1818

19+
- Removed `Navigation.Item` color change when focused ([#3562](https://github.com/Shopify/polaris-react/pull/3562))
20+
1921
### Documentation
2022

2123
### Development workflow

src/components/Navigation/Navigation.scss

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ $disabled-fade: 0.6;
132132

133133
&:active,
134134
&:active:hover {
135-
color: var(--p-text, color('indigo', 'dark'));
135+
color: var(--p-action-primary, color('indigo', 'dark'));
136136
@include no-focus-ring;
137137

138138
// stylelint-disable-next-line selector-max-specificity
@@ -300,8 +300,7 @@ $secondary-item-font-size: rem(15px);
300300
}
301301
}
302302

303-
&:hover,
304-
&:focus {
303+
&:hover {
305304
color: var(--p-text-subdued, color('indigo', 'dark'));
306305
}
307306

@@ -317,7 +316,7 @@ $secondary-item-font-size: rem(15px);
317316
}
318317

319318
&:active {
320-
color: var(--p-text, color('indigo', 'dark'));
319+
color: var(--p-action-primary, color('indigo', 'dark'));
321320
}
322321

323322
@include breakpoint-after(nav-min-window-corrected()) {
@@ -354,7 +353,7 @@ $secondary-item-font-size: rem(15px);
354353
color: var(--p-action-primary, color('indigo', 'dark'));
355354
}
356355
&:active {
357-
color: var(--p-action-primary-pressed, color('indigo', 'dark'));
356+
color: var(--p-action-primary, color('indigo', 'dark'));
358357
@include no-focus-ring;
359358
}
360359
}

0 commit comments

Comments
 (0)