Skip to content

Conversation

@alex-page
Copy link
Member

@alex-page alex-page commented Oct 26, 2020

WHY are these changes introduced?

The text color does not reflect active state and only does that when I click elsewhere on the page

screen_shot_2020-10-26_at_10 18 21_am

@sainihas

WHAT is this pull request doing?

Making sure that when clicking on a navigation item the :active state does not override the selected color.

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

Copy-paste this code in playground/Playground.tsx:
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}

🎩 checklist

  • Tested on mobile
  • Tested on multiple browsers
  • Tested for accessibility
  • Updated the component's README.md with documentation changes
  • Tophatted documentation changes in the style guide
  • For visual design changes, pinged one of @ HYPD, @ mirualves, @ sarahill, or @ ry5n to update the Polaris UI kit

@alex-page alex-page changed the title Adjust :active color for navigation [Navigation] Adjust :active color for selected items Oct 26, 2020
@alex-page alex-page self-assigned this Oct 26, 2020
Copy link
Member

@kyledurand kyledurand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2020

🟢 This pull request modifies 2 files and might impact 1 other files.

Details:
All files potentially affected (total: 1)
📄 UNRELEASED.md (total: 0)

Files potentially affected (total: 0)

🎨 src/components/Navigation/Navigation.scss (total: 1)

Files potentially affected (total: 1)

@kaelig
Copy link
Contributor

kaelig commented Oct 26, 2020

}

&:hover,
&:focus {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaelig removing this :focus color change fixes it up

@alex-page alex-page merged commit 8d03a7e into master Oct 27, 2020
@alex-page alex-page deleted the navigation-active branch October 27, 2020 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants