Previous button of the Pagination component has unnecessary right border

[meecrobe]

Issue summary

Previous button of the Pagination component has unnecessary right border when nextTooltip property is set.

Expected behavior

1px border between Prev and Next buttons.

Actual behavior

2px border between the buttons. Border radius of the Next button set to 0.

Steps to reproduce the problem

Sandbox: https://codesandbox.io/s/pywy3w8o7q

Specifications

• Are you using the React components? (Y/N): Y
• Polaris version number: 3.11.0
• Browser: Google Chrome Version 73.0.3683.86 (Official Build) (64-bit)
• Device: iMac (21.5-inch, Late 2012)
• Operating System: macOS Mojave 10.14.3 (18D109)

[ruairiphackett]

There's also an issue with margin-left and border-radius as its assumed the buttons will be siblings, with the styling based on first-child and last-child. As a result several styles aren't applied properly, with the next button getting styles for both first-child and last-child & not receiving the negative margin-left for :not(:first-child).

Relevant code

There's also similar issues when a previousTooltip is present:

or both tooltips:

Similarly there are issues with the plain buttons when they have tooltips.

[ruairiphackett]

Related issue here: #1279