Skip to content

Components with rem unit have layout problem. #431

@nonjene

Description

@nonjene

Originally posted by @ry5n in #296 (comment)

Issue summary

utilities.scss's $base-font-size set to 10px will cause layout problem in Chrome in which system's language is Chinese or Japanese.

Because at that env Chrome will limit the min font size to 12px, 10px will not take effect. It will cause components with rem unit have larger size.

Expected behavior

Set utilities.scss's $base-font-size to 12px

Actual behavior

You can easily recreate the issue by setting the the html element's font-size to 12px in Chrome's devtool.

Steps to reproduce the problem

  1. Change the system language to Chinese or Japanese

Specifications

  • Are you using the React components? (Y/N): Y
  • Polaris version number: v2.8 and v2.10
  • Browser: Chrome
  • Device: Macbook pro
  • Operating System: macOS High Sierra 10.13.6

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions