Modal Title - Vertical alignment

[laranoell]

Issue summary

The Modal title appears slightly mis-aligned, vertically.

Expected behavior

Title and close icon are vertically aligned

Actual behavior

Proposed Change:

Bump margin-top up to 0.4rem (from 0.2rem)

[dleroux]

Thanks @laranoell.

@sarahill, @ry5n is this something we want to adjust. Looking at CSS this looks intentional maybe? There's also a different spacing when the modal renders as a sheet.

[ry5n]

I haven’t looked at this in depth, but it seems like we should fix this as proposed. My guess is the alignment is off because we want the icon to always line up with the first line of the title, and not be centered with the whole title if the text wraps.

I bet an improved implementation could get us there.

[sarahill]

I'm for the proposed change. Makes sense and feel like it keeps it cleaner. 👍

[sarahill]

Ah looks like this has been fixed!