[DatePicker] Extract months and week names into en.json #1005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, I didn't realize @joshuajay was taking a stab at this here: #874 🙈 I guess I can close this then @joshuajay? |
|
They both handle the localisation in a different way, not sure which is better. Mine will take date formats into account when displaying the month/year together and does not need to be maintained by Shopify's translation efforts since it leverages an already implemented international standard for localising date formatting. This PR gives us more control over the translations, so there might be value in this over the PR I opened. |
chloerice
approved these changes
Feb 13, 2019
src/locales/en.json
Outdated
| "november": "November", | ||
| "december": "December" | ||
| }, | ||
| "daysAbbr": { |
There was a problem hiding this comment.
For clarity and for folks who don't speak English as a first language, I think we should spell this out.
Suggested change
| "daysAbbr": { | |
| "daysAbbreviated": { |
nimzco
force-pushed
the
extract_datepicker_strings
branch
from
aa59514 to
3a183fb
Compare
|
Awesome, thank you Chloe! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Resolves https://github.com/Shopify/intl-domestic-country-fit/issues/340
Currently, months and week names are hard coded in English, therefore, it breaks in other languages. See:
WHAT is this pull request doing?
en.jsonand useintl.translateto load them based on the month or weekdayHow to 🎩
en.jsonand see them rendered on the storybook.🎩 checklist