Remove lodash get #1013
Merged
Remove lodash get #1013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
AndrewMusgrave
force-pushed
the
rm-ld-get
branch
from
93216bb to
bc80ebd
Compare
|
In case you didn't know, if this doesn't need a changelog entry, you can add the |
solonaarmstrong-zz
approved these changes
Feb 13, 2019
elileto
reviewed
Feb 13, 2019
AndrewMusgrave
force-pushed
the
rm-ld-get
branch
from
bc80ebd to
784d7db
Compare
AndrewMusgrave
commented
Feb 28, 2019
| @@ -0,0 +1,32 @@ | |||
| import {GeneralObject} from '../types'; | |||
|
|
|||
| const OBJECT_NOTATION_MATCHER = /\[(.*?)\]|(\w+)/g; | |||
There was a problem hiding this comment.
I'm by no means a regex wizard so all suggestions are greatly welcomed 🙏
AndrewMusgrave
force-pushed
the
rm-ld-get
branch
from
784d7db to
50ec027
Compare
elileto
approved these changes
Mar 4, 2019
AndrewMusgrave
force-pushed
the
rm-ld-get
branch
from
50ec027 to
e365b71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Part of removing lodash #991
WHAT is this pull request doing?
Creating a
getfunction and using that instead of_.getHow to 🎩
Test pass? 💯
TODO: