-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Remove lodash merge #1018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove lodash merge #1018
Conversation
Repeating my query from #1010 here too: I'm not too familiar with how mergeAppProviderOptions() and legacy context stuff does its thing, but do we need a deep merge there and in the withAppProvider / withSticky HoCs or could we get away with a shallow one using Object.assign()? |
Unfortunately merging context requires a deep merge since the user could define partial context and have it collide with |
Elegant! 👌 |
d63f0db
to
9ce3a91
Compare
Ready for 👀 |
9ce3a91
to
1d05651
Compare
I rebased it because conflicts with Michelle's autobind. |
I assume we skip change logs for these? |
Although I wonder why percy changed. It's not being translated? |
1d05651
to
9ce3a91
Compare
Iv'e been adding them to |
487d6ca
to
ded45a0
Compare
WHY are these changes introduced?
Part of removing lodash #991
WHAT is this pull request doing?
Creating a less featureful
merge
function and using that instead of_.merge
How to 🎩
Test pass? 💯
TODO: