This repository was archived by the owner on Sep 30, 2025. It is now read-only.
Support dynamic fontsizes in iOS devices #10181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/snapit |
|
🫰✨ Thanks @ssetem! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/polaris-migrator@0.0.0-snapshot-release-20230823134224yarn add @shopify/polaris@0.0.0-snapshot-release-20230823134224 |
fortmarek
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
Tested this on my simulator and can confirm this works: https://screenshot.click/23-59-152vf-zw6aq.mp4 ❤️
sam-b-rose
approved these changes
Aug 23, 2023
.changeset/olive-fishes-provide.md
Outdated
| '@shopify/polaris': minor | ||
| --- | ||
|
|
||
| supports dynamic fontsizes for iOS |
There was a problem hiding this comment.
Suggested change
| supports dynamic fontsizes for iOS | |
| Added support for [Dynamic Type](https://developer.apple.com/documentation/uikit/uifont/scaling_fonts_automatically) in iOS |
ssetem
force-pushed
the
ios-dynamic-font-size
branch
from
79fa015 to
fb5379a
Compare
kyledurand
approved these changes
Aug 23, 2023
Merged
sam-b-rose
pushed a commit
that referenced
this pull request
Aug 24, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-migrator@0.20.0 ### Minor Changes - [#10101](#10101) [`e6a2d352a`](e6a2d35) Thanks [@samrose3](https://github.com/samrose3)! - Removed the `@shopify/polaris-cli` and `@shopify/polaris-codemods` package in favor of using only the `@shopify/polaris-migrator`. Removing these packages will provide the following benefits: - Improve CI time by removing extra packages from our build, test, and lint workflows - Reduce confusion on where to add new migrations or update previous migrations - Clean up ESLint configs, reduce changelog entries, and remove package dependencies - [#10071](#10071) [`23c1391aa`](23c1391) Thanks [@kyledurand](https://github.com/kyledurand)! - Added support for compound components and adding new prop values in the react-rename-component-prop migration ## @shopify/polaris@11.13.0 ### Minor Changes - [#10086](#10086) [`5a5b3795a`](5a5b379) Thanks [@joelzwarrington](https://github.com/joelzwarrington)! - [Modal] Activator no longer wrapped in Box - [#10183](#10183) [`7891c7ed9`](7891c7e) Thanks [@kyledurand](https://github.com/kyledurand)! - Deprecate connectedDisclosure prop on button - [#10181](#10181) [`219be15aa`](219be15) Thanks [@ssetem](https://github.com/ssetem)! - Added support for [Dynamic Type](https://developer.apple.com/documentation/uikit/uifont/scaling_fonts_automatically) in iOS ### Patch Changes - [#10056](#10056) [`5ecaafc2b`](5ecaafc) Thanks [@jesstelford](https://github.com/jesstelford)! - [ResourceList] Remove layout jank when bulk actions enabled and item selected - [`bc1f4aab1`](bc1f4aa) Thanks [@samrose3](https://github.com/samrose3)! - Reduced surrounding margin of Tooltip to allow for interaction with nearby UI elements. ## polaris.shopify.com@0.57.1 ### Patch Changes - [#10186](#10186) [`b340df129`](b340df1) Thanks [@m4thieulavoie](https://github.com/m4thieulavoie)! - Fixed landing page for sandbox - Updated dependencies \[[`5a5b3795a`](5a5b379), [`7891c7ed9`](7891c7e), [`5ecaafc2b`](5ecaafc), [`bc1f4aab1`](bc1f4aa), [`219be15aa`](219be15)]: - @shopify/polaris@11.13.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sam-b-rose
added a commit
that referenced
this pull request
Aug 28, 2023
* main: Fix rename prop migration (#10215) Update translations: default (#10219) [Avatar] Override SE23 background override with imageHasLoaded (#10211) Create Code style guide.md (#10176) ActionsList filtering (#9907) Version Packages (#10078) Support dynamic fontsizes in iOS devices (#10181) Fix migration resolution path (#10188) [Button] Deprecate connectedDisclosure (#10183) Update sandbox.md (#10186) Allow migrator to target subcomponents and change prop values (#10071) Remove `polaris-cli` and `polaris-codemods` packages (#10101) Bump loader-utils from 1.4.0 to 1.4.2 (#7725) Bump deep-object-diff from 1.1.7 to 1.1.9 (#7734) Bump decode-uri-component from 0.2.0 to 0.2.2 (#7832) Bump webpack from 5.72.0 to 5.76.0 (#8667) Bump fastify from 4.5.3 to 4.15.0 (#8750) [Modal] Activator no longer wrapped in Box (#10086) Fix icon optimize config (#10087) [ResourceList] Remove layout jank when bulk actions enabled and item selected
sam-b-rose
added a commit
that referenced
this pull request
Aug 28, 2023
* main: Fix rename prop migration (#10215) Update translations: default (#10219) [Avatar] Override SE23 background override with imageHasLoaded (#10211) Create Code style guide.md (#10176) ActionsList filtering (#9907) Version Packages (#10078) Support dynamic fontsizes in iOS devices (#10181) Fix migration resolution path (#10188) [Button] Deprecate connectedDisclosure (#10183) Update sandbox.md (#10186) Allow migrator to target subcomponents and change prop values (#10071) Remove `polaris-cli` and `polaris-codemods` packages (#10101) Bump loader-utils from 1.4.0 to 1.4.2 (#7725) Bump deep-object-diff from 1.1.7 to 1.1.9 (#7734) Bump decode-uri-component from 0.2.0 to 0.2.2 (#7832) Bump webpack from 5.72.0 to 5.76.0 (#8667) Bump fastify from 4.5.3 to 4.15.0 (#8750) [Modal] Activator no longer wrapped in Box (#10086) Fix icon optimize config (#10087) [ResourceList] Remove layout jank when bulk actions enabled and item selected
kyledurand
added a commit
that referenced
this pull request
Aug 31, 2023
This reverts commit 219be15.
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Currently Webviews & Mobile Web in iOS don't respect the users preference for Font Scale which is quite inaccessible. <!-- Context about the problem that’s being addressed. --> This PR introduces the use of font: -apple-system-body if it is supported. Inspired by this [dev.to article](https://dev.to/colingourlay/how-to-support-apple-s-dynamic-text-in-your-web-content-with-css-40c0#:~:text=If%20you've%20never%20seen,apple%2Dsystem%2Dbody%20) ### WHAT is this pull request doing? <details> <summary>Before</summary> <img src="https://github.com/Shopify/polaris/assets/703938/f1adb621-2982-4cc0-8946-bd5403e2a558" width="300"/> </details> <details> <summary>After</summary> <img src="https://github.com/Shopify/polaris/assets/703938/a213b56e-80ba-4fca-b09a-226ec2f6bec2" width="300"/> </details> <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 1. Open iOS simulator 2. Open Safari within the iOS Simulator 3. Open polaris storybook using this url https://5d559397bae39100201eedc1-krdvxqhrcy.chromatic.com/?path=/story/all-components-text--variants 4. Change Fontscale in `Settings > Accessibility > Display & Text Size > Larger Text ` (using the slider at the bottom) 5. Switch back to Safari 6. Verify the font scale has updated to match the preference in accessibility ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [x] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
ascherkus
pushed a commit
to ascherkus/polaris
that referenced
this pull request
Feb 19, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-migrator@0.20.0 ### Minor Changes - [Shopify#10101](Shopify#10101) [`e6a2d352a`](Shopify@2d142bb) Thanks [@samrose3](https://github.com/samrose3)! - Removed the `@shopify/polaris-cli` and `@shopify/polaris-codemods` package in favor of using only the `@shopify/polaris-migrator`. Removing these packages will provide the following benefits: - Improve CI time by removing extra packages from our build, test, and lint workflows - Reduce confusion on where to add new migrations or update previous migrations - Clean up ESLint configs, reduce changelog entries, and remove package dependencies - [Shopify#10071](Shopify#10071) [`23c1391aa`](Shopify@4e11e7a) Thanks [@kyledurand](https://github.com/kyledurand)! - Added support for compound components and adding new prop values in the react-rename-component-prop migration ## @shopify/polaris@11.13.0 ### Minor Changes - [Shopify#10086](Shopify#10086) [`5a5b3795a`](Shopify@f8cb874) Thanks [@joelzwarrington](https://github.com/joelzwarrington)! - [Modal] Activator no longer wrapped in Box - [Shopify#10183](Shopify#10183) [`7891c7ed9`](Shopify@5febc40) Thanks [@kyledurand](https://github.com/kyledurand)! - Deprecate connectedDisclosure prop on button - [Shopify#10181](Shopify#10181) [`219be15aa`](Shopify@5892203) Thanks [@ssetem](https://github.com/ssetem)! - Added support for [Dynamic Type](https://developer.apple.com/documentation/uikit/uifont/scaling_fonts_automatically) in iOS ### Patch Changes - [Shopify#10056](Shopify#10056) [`5ecaafc2b`](Shopify@06a127d) Thanks [@jesstelford](https://github.com/jesstelford)! - [ResourceList] Remove layout jank when bulk actions enabled and item selected - [`bc1f4aab1`](Shopify@9d26367) Thanks [@samrose3](https://github.com/samrose3)! - Reduced surrounding margin of Tooltip to allow for interaction with nearby UI elements. ## polaris.shopify.com@0.57.1 ### Patch Changes - [Shopify#10186](Shopify#10186) [`b340df129`](Shopify@95e35db) Thanks [@m4thieulavoie](https://github.com/m4thieulavoie)! - Fixed landing page for sandbox - Updated dependencies \[[`5a5b3795a`](Shopify@f8cb874), [`7891c7ed9`](Shopify@5febc40), [`5ecaafc2b`](Shopify@06a127d), [`bc1f4aab1`](Shopify@9d26367), [`219be15aa`](Shopify@5892203)]: - @shopify/polaris@11.13.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Currently Webviews & Mobile Web in iOS don't respect the users preference for Font Scale which is quite inaccessible.
This PR introduces the use of font: -apple-system-body if it is supported.
Inspired by this dev.to article
WHAT is this pull request doing?
Before
After
How to 🎩
Settings > Accessibility > Display & Text Size > Larger Text(using the slider at the bottom)🎩 checklist
README.mdwith documentation changes