Skip to content

[Button] Deprecate connectedDisclosure #10183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 23, 2023
Merged

[Button] Deprecate connectedDisclosure #10183

merged 4 commits into from
Aug 23, 2023

Conversation

kyledurand
Copy link
Member

WHY are these changes introduced?

Part of #10126

@kyledurand kyledurand force-pushed the button-deprecate-connected-dislosure branch from 1d4e4e0 to 6f6df3d Compare August 23, 2023 14:43
sam-b-rose
sam-b-rose approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@sam-b-rose sam-b-rose left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Great composition example in storybook and the docs! So much better 👍

.changeset/famous-stingrays-change.md
'@shopify/polaris': minor
---

Deprecate connectedDisclosure prop on button
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Deprecate connectedDisclosure prop on button
Deprecated `connectedDisclosure` prop on Button

aveline
aveline reviewed Aug 23, 2023
View reviewed changes
polaris-react/src/components/Button/Button.stories.tsx
preferredAlignment="right"
activator={
<Button
onClick={() => setActive(true)}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth keeping the primary prop here to avoid a Chromatic diff?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I can add it 👍

aveline
aveline approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@aveline aveline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see this accomplished with composability rather than configuration 🙌

@kyledurand kyledurand marked this pull request as ready for review August 23, 2023 20:19
@kyledurand kyledurand merged commit 7891c7e into main Aug 23, 2023
@kyledurand kyledurand deleted the button-deprecate-connected-dislosure branch August 23, 2023 20:19
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Aug 23, 2023
Merged
sam-b-rose pushed a commit that referenced this pull request Aug 24, 2023
@shopify-github-actions-access @github-actions
Version Packages (#10078)
295feef 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris-migrator@0.20.0

### Minor Changes

- [#10101](#10101)
[`e6a2d352a`](e6a2d35)
Thanks [@samrose3](https://github.com/samrose3)! - Removed the
`@shopify/polaris-cli` and `@shopify/polaris-codemods` package in favor
of using only the `@shopify/polaris-migrator`.

    Removing these packages will provide the following benefits:

- Improve CI time by removing extra packages from our build, test, and
lint workflows
- Reduce confusion on where to add new migrations or update previous
migrations
- Clean up ESLint configs, reduce changelog entries, and remove package
dependencies


- [#10071](#10071)
[`23c1391aa`](23c1391)
Thanks [@kyledurand](https://github.com/kyledurand)! - Added support for
compound components and adding new prop values in the
react-rename-component-prop migration

## @shopify/polaris@11.13.0

### Minor Changes

- [#10086](#10086)
[`5a5b3795a`](5a5b379)
Thanks [@joelzwarrington](https://github.com/joelzwarrington)! - [Modal]
Activator no longer wrapped in Box


- [#10183](#10183)
[`7891c7ed9`](7891c7e)
Thanks [@kyledurand](https://github.com/kyledurand)! - Deprecate
connectedDisclosure prop on button


- [#10181](#10181)
[`219be15aa`](219be15)
Thanks [@ssetem](https://github.com/ssetem)! - Added support for
[Dynamic
Type](https://developer.apple.com/documentation/uikit/uifont/scaling_fonts_automatically)
in iOS

### Patch Changes

- [#10056](#10056)
[`5ecaafc2b`](5ecaafc)
Thanks [@jesstelford](https://github.com/jesstelford)! - [ResourceList]
Remove layout jank when bulk actions enabled and item selected


-
[`bc1f4aab1`](bc1f4aa)
Thanks [@samrose3](https://github.com/samrose3)! - Reduced surrounding
margin of Tooltip to allow for interaction with nearby UI elements.

## polaris.shopify.com@0.57.1

### Patch Changes

- [#10186](#10186)
[`b340df129`](b340df1)
Thanks [@m4thieulavoie](https://github.com/m4thieulavoie)! - Fixed
landing page for sandbox

- Updated dependencies
\[[`5a5b3795a`](5a5b379),
[`7891c7ed9`](7891c7e),
[`5ecaafc2b`](5ecaafc),
[`bc1f4aab1`](bc1f4aa),
[`219be15aa`](219be15)]:
    -   @shopify/polaris@11.13.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sam-b-rose added a commit that referenced this pull request Aug 28, 2023
@sam-b-rose
Merge branch 'main' into update-next
8152b28 
* main:
  Fix rename prop migration (#10215)
  Update translations: default (#10219)
  [Avatar] Override SE23 background override with imageHasLoaded (#10211)
  Create Code style guide.md (#10176)
  ActionsList filtering (#9907)
  Version Packages (#10078)
  Support dynamic fontsizes in iOS devices (#10181)
  Fix migration resolution path (#10188)
  [Button] Deprecate connectedDisclosure  (#10183)
  Update sandbox.md (#10186)
  Allow migrator to target subcomponents and change prop values (#10071)
  Remove `polaris-cli` and `polaris-codemods` packages (#10101)
  Bump loader-utils from 1.4.0 to 1.4.2 (#7725)
  Bump deep-object-diff from 1.1.7 to 1.1.9 (#7734)
  Bump decode-uri-component from 0.2.0 to 0.2.2 (#7832)
  Bump webpack from 5.72.0 to 5.76.0 (#8667)
  Bump fastify from 4.5.3 to 4.15.0 (#8750)
  [Modal] Activator no longer wrapped in Box (#10086)
  Fix icon optimize config (#10087)
  [ResourceList] Remove layout jank when bulk actions enabled and item selected
sam-b-rose added a commit that referenced this pull request Aug 28, 2023
@sam-b-rose
Merge branch 'main' into update-next
56ee593 
* main:
  Fix rename prop migration (#10215)
  Update translations: default (#10219)
  [Avatar] Override SE23 background override with imageHasLoaded (#10211)
  Create Code style guide.md (#10176)
  ActionsList filtering (#9907)
  Version Packages (#10078)
  Support dynamic fontsizes in iOS devices (#10181)
  Fix migration resolution path (#10188)
  [Button] Deprecate connectedDisclosure  (#10183)
  Update sandbox.md (#10186)
  Allow migrator to target subcomponents and change prop values (#10071)
  Remove `polaris-cli` and `polaris-codemods` packages (#10101)
  Bump loader-utils from 1.4.0 to 1.4.2 (#7725)
  Bump deep-object-diff from 1.1.7 to 1.1.9 (#7734)
  Bump decode-uri-component from 0.2.0 to 0.2.2 (#7832)
  Bump webpack from 5.72.0 to 5.76.0 (#8667)
  Bump fastify from 4.5.3 to 4.15.0 (#8750)
  [Modal] Activator no longer wrapped in Box (#10086)
  Fix icon optimize config (#10087)
  [ResourceList] Remove layout jank when bulk actions enabled and item selected
AnnaCheba pushed a commit to AnnaCheba/polaris that referenced this pull request Apr 22, 2024
@kyledurand
[Button] Deprecate connectedDisclosure (Shopify#10183)
5febc40 
<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

### WHY are these changes introduced?

Part of Shopify#10126
ascherkus pushed a commit to ascherkus/polaris that referenced this pull request Feb 19, 2025
@shopify-github-actions-access @github-actions
Version Packages (Shopify#10078)
a106eca 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris-migrator@0.20.0

### Minor Changes

- [Shopify#10101](Shopify#10101)
[`e6a2d352a`](Shopify@2d142bb)
Thanks [@samrose3](https://github.com/samrose3)! - Removed the
`@shopify/polaris-cli` and `@shopify/polaris-codemods` package in favor
of using only the `@shopify/polaris-migrator`.

    Removing these packages will provide the following benefits:

- Improve CI time by removing extra packages from our build, test, and
lint workflows
- Reduce confusion on where to add new migrations or update previous
migrations
- Clean up ESLint configs, reduce changelog entries, and remove package
dependencies


- [Shopify#10071](Shopify#10071)
[`23c1391aa`](Shopify@4e11e7a)
Thanks [@kyledurand](https://github.com/kyledurand)! - Added support for
compound components and adding new prop values in the
react-rename-component-prop migration

## @shopify/polaris@11.13.0

### Minor Changes

- [Shopify#10086](Shopify#10086)
[`5a5b3795a`](Shopify@f8cb874)
Thanks [@joelzwarrington](https://github.com/joelzwarrington)! - [Modal]
Activator no longer wrapped in Box


- [Shopify#10183](Shopify#10183)
[`7891c7ed9`](Shopify@5febc40)
Thanks [@kyledurand](https://github.com/kyledurand)! - Deprecate
connectedDisclosure prop on button


- [Shopify#10181](Shopify#10181)
[`219be15aa`](Shopify@5892203)
Thanks [@ssetem](https://github.com/ssetem)! - Added support for
[Dynamic
Type](https://developer.apple.com/documentation/uikit/uifont/scaling_fonts_automatically)
in iOS

### Patch Changes

- [Shopify#10056](Shopify#10056)
[`5ecaafc2b`](Shopify@06a127d)
Thanks [@jesstelford](https://github.com/jesstelford)! - [ResourceList]
Remove layout jank when bulk actions enabled and item selected


-
[`bc1f4aab1`](Shopify@9d26367)
Thanks [@samrose3](https://github.com/samrose3)! - Reduced surrounding
margin of Tooltip to allow for interaction with nearby UI elements.

## polaris.shopify.com@0.57.1

### Patch Changes

- [Shopify#10186](Shopify#10186)
[`b340df129`](Shopify@95e35db)
Thanks [@m4thieulavoie](https://github.com/m4thieulavoie)! - Fixed
landing page for sandbox

- Updated dependencies
\[[`5a5b3795a`](Shopify@f8cb874),
[`7891c7ed9`](Shopify@5febc40),
[`5ecaafc2b`](Shopify@06a127d),
[`bc1f4aab1`](Shopify@9d26367),
[`219be15aa`](Shopify@5892203)]:
    -   @shopify/polaris@11.13.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sam-b-rose sam-b-rose sam-b-rose approved these changes

+1 more reviewer

@aveline aveline aveline approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kyledurand @aveline @sam-b-rose