-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[Skeleton] Add skeleton for thumbnails #1041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d35858a to
603642d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks excellent!! Thank you so much for taking this on 🙌
|
|
||
| ### New components | ||
|
|
||
| - `SkeletonThumbnail` for representing thumbnails in loading state |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
Co-Authored-By: helloneele <helloneele@users.noreply.github.com>
|
Thanks so much for getting to this so quickly! |
elileto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
* [Skeleton] Add skeleton for thumbnails * Update src/components/SkeletonThumbnail/README.md Co-Authored-By: helloneele <helloneele@users.noreply.github.com> * update version in README.md * update README.md
WHY are these changes introduced?
Resolves #1039
I chose 3 size options for now, because in the issues screenshot the thumbnails seem to have a size of 30px, not sure if it is accurate or scaled down, though. In the Home sidebar and on Home cards thumbnails have a size of 40px whereas in other sections of the admin (products) thumbnails have a size of 50px.
WHAT is this pull request doing?
Adds a new component that can be used for thumbnails while in loading state
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
Copy-paste this code in
playground/Playground.tsx:🎩 checklist