Skip to content

Conversation

dpersing
Copy link

@dpersing dpersing commented Feb 20, 2019

WHY are these changes introduced?

Adds accessibility guidance for the banner component, to appear in polaris-react docs and in the style guide.

See the draft Google doc for editing history for these changes and updates for other components and pages.

WHAT is this pull request doing?

  • Adds accessibility documentation for the banner component (web, iOS, and Android)
  • Adds an entry to UNRELEASED.md

How to 🎩

  1. Check out master from polaris-styleguide.
  2. In another Terminal tab or window, check out this branch from polaris-react and run the instructions for testing in a consuming project.
  3. In the polaris-styleguide tab, run dev up && dev start.
  4. View changes after examples and props: https://polaris.myshopify.io/components/feedback-indicators/banner (web, iOS, and Android)

Screenshot

Web content:
Banner accessibility updates for web

@BPScott BPScott temporarily deployed to polaris-react-pr-1071 February 20, 2019 22:25 Inactive
@dpersing
Copy link
Author

@danrosenthal and @sadiesaurus, would love your 👀 !

Copy link
Contributor

@sadiesaurus sadiesaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One teensy edit but otherwise looks fantastic to me 👍

sadieredden and others added 2 commits February 26, 2019 10:46
Co-Authored-By: dpersing <devon.persing@shopify.com>
Co-Authored-By: dpersing <devon.persing@shopify.com>
@BPScott BPScott temporarily deployed to polaris-react-pr-1071 February 26, 2019 18:47 Inactive
@BPScott BPScott temporarily deployed to polaris-react-pr-1071 February 26, 2019 18:47 Inactive
@BPScott BPScott temporarily deployed to polaris-react-pr-1071 February 26, 2019 18:50 Inactive
@BPScott BPScott temporarily deployed to polaris-react-pr-1071 February 26, 2019 18:55 Inactive
Copy link

@danrosenthal danrosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants