-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[Navigation] badge accepts react element #1142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👋 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines. You can also join #polaris on the Shopify Partners Slack. |
ec8d870
to
f36a45c
Compare
f36a45c
to
dcde31d
Compare
dcde31d
to
bfff67d
Compare
lemonmade
requested changes
Mar 7, 2019
bfff67d
to
82a5232
Compare
82a5232
to
d2525f6
Compare
lemonmade
requested changes
Mar 11, 2019
d2525f6
to
af2d41a
Compare
lemonmade
approved these changes
Mar 11, 2019
af2d41a
to
b35d656
Compare
🎉 Thanks for your contribution to Polaris React! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Minimizes impact of re-rendering navigation if the badge relies on a query to resolve. More detail here: https://github.com/Shopify/web/issues/10481
WHAT is this pull request doing?
Allows the nav items badge property to take a react node prop value.
How to 🎩
Copy-paste this code in
playground/Playground.tsx
:🎩 checklist