Apply flat button styles for light-mobile theme
#11552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam-b-rose
force-pushed
the
mobile-button-styles
branch
from
6ab0833 to
65de0ad
Compare
Member
Author
|
/snapit |
Contributor
|
🫰✨ Thanks @sam-b-rose! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/polaris-migrator@0.0.0-snapshot-release-20240204234746yarn add @shopify/polaris@0.0.0-snapshot-release-20240204234746yarn add @shopify/polaris-tokens@0.0.0-snapshot-release-20240204234746yarn add @shopify/stylelint-polaris@0.0.0-snapshot-release-20240204234746 |
sam-b-rose
changed the title
light-mobile theme
sam-b-rose
force-pushed
the
mobile-button-styles
branch
2 times, most recently
from
af49099 to
75f1b8e
Compare
sam-b-rose
force-pushed
the
mobile-button-styles
branch
from
75f1b8e to
8ce099e
Compare
heyjoethomas
approved these changes
Feb 8, 2024
Merged
sam-b-rose
pushed a commit
that referenced
this pull request
Feb 9, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris@12.15.0 ### Minor Changes - [#11552](#11552) [`04e462816`](04e4628) Thanks [@sam-b-rose](https://github.com/sam-b-rose)! - Applied native mobile styles to Button component for the light-mobile theme ### Patch Changes - [#11570](#11570) [`e7f1961e1`](e7f1961) Thanks [@chloerice](https://github.com/chloerice)! - Fixed the position of `SelectAllActions` when inside of an offset scrollable container - Updated dependencies \[[`04e462816`](04e4628)]: - @shopify/polaris-tokens@8.8.0 ## @shopify/polaris-tokens@8.8.0 ### Minor Changes - [#11552](#11552) [`04e462816`](04e4628) Thanks [@sam-b-rose](https://github.com/sam-b-rose)! - Applied native mobile styles to Button component for the light-mobile theme ## @shopify/polaris-migrator@0.27.4 ### Patch Changes - Updated dependencies \[[`04e462816`](04e4628)]: - @shopify/polaris-tokens@8.8.0 - @shopify/stylelint-polaris@15.2.2 ## @shopify/stylelint-polaris@15.2.2 ### Patch Changes - Updated dependencies \[[`04e462816`](04e4628)]: - @shopify/polaris-tokens@8.8.0 ## polaris-for-vscode@0.9.6 ### Patch Changes - Updated dependencies \[[`04e462816`](04e4628)]: - @shopify/polaris-tokens@8.8.0 ## polaris.shopify.com@0.62.8 ### Patch Changes - Updated dependencies \[[`04e462816`](04e4628), [`e7f1961e1`](e7f1961)]: - @shopify/polaris@12.15.0 - @shopify/polaris-tokens@8.8.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
6 tasks
lgriffee
added a commit
that referenced
this pull request
Feb 21, 2024
### WHY are these changes introduced? Fixes #11632 Reverts changes made to mobile button styles in #11552 Styles between native mobile and web mobile are currently not aligned so if we add any native mobile styles into our design system they will create discrepancies with screens at the MD (768px) breakpoint and above. In this case, adding in native mobile button styles resulted in unexpected font styles (weight, size, line-height) below the MD breakpoint (768px) in web mobile. ### WHAT is this pull request doing? | Before | After | | -- | -- | || | Before | After | | -- | -- | | <video src="https://github.com/Shopify/polaris/assets/21976492/05128504-ed1f-4289-a448-8ebec4015577"></video>|<video src="https://github.com/Shopify/polaris/assets/21976492/41a3e932-7da5-457c-ab94-8c4a64313eb0"></video>| ### How to 🎩 _Toggle between 768px and 767px_ - Before: https://admin.shopify.com/store/laura-griffee-test-store/dashboards - After: https://admin.web.button-revert.laura-griffee.us.spin.dev/store/shop1/dashboards ### 🎩 checklist - [x] Tested a [snapshot](https://github.com/Shopify/polaris/blob/main/documentation/Releasing.md#-snapshot-releases) - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
### WHY are these changes introduced? Part of Shopify/polaris-internal#1399 This PR updates the `light-mobile` theme to match the Polaris Mobile native flat style. - Removes the primary gradient - Removes the shadow bevel effect - Applies a solid "border" around the default (secondary) button style - Only applies the "pressed" transition movement for non-mobile screens - Updates the font size and weight to match mobile on small screens 🌀 [Spin URL](https://admin.web.mobile-button.sam-rose.us.spin.dev/store/shop1) ### WHAT is this pull request doing? | Desktop | Mobile | | --- | --- | | <img width="576" alt="desktop" src="https://github.com/Shopify/polaris/assets/11774595/4d0ead6e-3855-4bf8-9041-3e8acdffbbdf"> | <img width="576" alt="mobile" src="https://github.com/Shopify/polaris/assets/11774595/dad25a9d-c0a2-4d4c-a8e9-0a44bd86dfb2"> | ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#install-dependencies-and-build-workspaces) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested a [snapshot](https://github.com/Shopify/polaris/blob/main/documentation/Releasing.md#-snapshot-releases) - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
…fy#11624) ### WHY are these changes introduced? Fixes Shopify#11632 Reverts changes made to mobile button styles in Shopify#11552 Styles between native mobile and web mobile are currently not aligned so if we add any native mobile styles into our design system they will create discrepancies with screens at the MD (768px) breakpoint and above. In this case, adding in native mobile button styles resulted in unexpected font styles (weight, size, line-height) below the MD breakpoint (768px) in web mobile. ### WHAT is this pull request doing? | Before | After | | -- | -- | || | Before | After | | -- | -- | | <video src="https://github.com/Shopify/polaris/assets/21976492/05128504-ed1f-4289-a448-8ebec4015577"></video>|<video src="https://github.com/Shopify/polaris/assets/21976492/41a3e932-7da5-457c-ab94-8c4a64313eb0"></video>| ### How to 🎩 _Toggle between 768px and 767px_ - Before: https://admin.shopify.com/store/laura-griffee-test-store/dashboards - After: https://admin.web.button-revert.laura-griffee.us.spin.dev/store/shop1/dashboards ### 🎩 checklist - [x] Tested a [snapshot](https://github.com/Shopify/polaris/blob/main/documentation/Releasing.md#-snapshot-releases) - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Part of https://github.com/Shopify/polaris-internal/issues/1399
This PR updates the
light-mobiletheme to match the Polaris Mobile native flat style.🌀 Spin URL
WHAT is this pull request doing?
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
🎩 checklist
README.mdwith documentation changes