🔥 icons index #1195
Merged
🔥 icons index #1195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BPScott
approved these changes
Mar 14, 2019
once the build queue has calmed down and percy passes
added 2 commits
March 15, 2019 11:18
amrocha
force-pushed
the
burn-icons-index
branch
from
0ea009d to
e53592f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
After discussion with Chris and the rest of the team we decided direct imports are a better default for most projects, instead of re-exporting from an index file, so here we are :D
WHAT is this pull request doing?
Removing the index file and just importing icons directly wherever needed
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
Just make sure existing stuff didn't break I guess
ground/Playground.tsx: