[Collapsible] Add animateIn prop value #11979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyledurand
force-pushed
the
collapsible_add-aminate-in
branch
from
92d0d62 to
f40705d
Compare
sophschneider
approved these changes
May 3, 2024
|
Not a bug 😅 @sophschneider. It's being caused by inline stack removing the gap when display: none is added when collapsible is fully closed. I removed the gap property in the example to show a smoother transition |
Merged
chloerice
pushed a commit
that referenced
this pull request
May 6, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris@13.3.0 ### Minor Changes - [#11979](#11979) [`982491f0f`](982491f) Thanks [@kyledurand](https://github.com/kyledurand)! - Added `animateIn` transition option to Collapsible - [#11967](#11967) [`e50472f85`](e50472f) Thanks [@kyledurand](https://github.com/kyledurand)! - Added `variant` prop to Collapsible ### Patch Changes - [#11976](#11976) [`4f3bf9948`](4f3bf99) Thanks [@chloerice](https://github.com/chloerice)! - Fixed sibling `FormLayout.Item` widths not remaining equal when wrapped in `FormLayout.Group` - [#11945](#11945) [`b59743a76`](b59743a) Thanks [@sophschneider](https://github.com/sophschneider)! - Added offset width to reframe `Frame` and passed reframe scroll container to sticky manager in `AppProvider` - [#11965](#11965) [`7a702388d`](7a70238) Thanks [@sophschneider](https://github.com/sophschneider)! - Added scrollbar styles for reframe - [#11944](#11944) [`d1d69e919`](d1d69e9) Thanks [@stefanlegg](https://github.com/stefanlegg)! - Add support for hiding selectable checkbox on a per `IndexTable.Row` basis via `hideSelectable` prop\` - [#11947](#11947) [`995079cc7`](995079c) Thanks [@sophschneider](https://github.com/sophschneider)! - Fixed `Sticky` to update sticky items when props change - Updated dependencies \[[`12dbc2cd8`](12dbc2c), [`8ce6211c9`](8ce6211), [`7a702388d`](7a70238)]: - @shopify/polaris-tokens@9.1.0 ## @shopify/polaris-tokens@9.1.0 ### Minor Changes - [#11965](#11965) [`7a702388d`](7a70238) Thanks [@sophschneider](https://github.com/sophschneider)! - Added `color-scrollbar-thumb-bg` token ### Patch Changes - [#11981](#11981) [`12dbc2cd8`](12dbc2c) Thanks [@sophschneider](https://github.com/sophschneider)! - Updated internal only whiteAlpha scale and dark experimental theme with new values - [#11853](#11853) [`8ce6211c9`](8ce6211) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Added `"sideEffect": "false"` to the `package.json` to enable treeshaking ## @shopify/polaris-migrator@1.0.2 ### Patch Changes - Updated dependencies \[[`12dbc2cd8`](12dbc2c), [`8ce6211c9`](8ce6211), [`7a702388d`](7a70238)]: - @shopify/polaris-tokens@9.1.0 - @shopify/stylelint-polaris@16.0.2 ## @shopify/stylelint-polaris@16.0.2 ### Patch Changes - Updated dependencies \[[`12dbc2cd8`](12dbc2c), [`8ce6211c9`](8ce6211), [`7a702388d`](7a70238)]: - @shopify/polaris-tokens@9.1.0 ## polaris-for-vscode@1.0.2 ### Patch Changes - Updated dependencies \[[`12dbc2cd8`](12dbc2c), [`8ce6211c9`](8ce6211), [`7a702388d`](7a70238)]: - @shopify/polaris-tokens@9.1.0 ## polaris.shopify.com@1.0.5 ### Patch Changes - Updated dependencies \[[`4f3bf9948`](4f3bf99), [`b59743a76`](b59743a), [`12dbc2cd8`](12dbc2c), [`982491f0f`](982491f), [`7a702388d`](7a70238), [`8ce6211c9`](8ce6211), [`e50472f85`](e50472f), [`d1d69e919`](d1d69e9), [`995079cc7`](995079c), [`7a702388d`](7a70238)]: - @shopify/polaris@13.3.0 - @shopify/polaris-tokens@9.1.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Part of https://github.com/Shopify/polaris-backlog/issues/1606
WHAT is this pull request doing?
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
🎩 checklist
README.mdwith documentation changes