Skip to content

[ResourceList] Fix checkbox / action visibility on different breakpoints / select mode #1333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2019
Merged

[ResourceList] Fix checkbox / action visibility on different breakpoints / select mode #1333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be6261c
Fix action visibility on different breakpoints
AndrewMusgrave Apr 17, 2019
53cdd41
changelog
AndrewMusgrave Apr 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions UNRELEASED.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ Use [the changelog guidelines](https://git.io/polaris-changelog-guidelines) to f

### Bug fixes

- Fixed `ResourceList` actions from show at incorrect breakpoints or while in select mode ([#1333](https://github.com/Shopify/polaris-react/pull/1333))
- Fixed Search overlay stretching below the viewport ([#1260](https://github.com/Shopify/polaris-react/pull/1260))
- Added `onChange` and `value` to select `AppProvider` examples to remove console errors ([#1320](https://github.com/Shopify/polaris-react/pull/1320))
- Fixed promoted bulk actions in `ResourceList` not properly disabling ([#1317](https://github.com/Shopify/polaris-react/pull/1317)) (thanks [@jineshshah36](https://github.com/jineshshah36) for the [issue report](https://github.com/Shopify/polaris-react/issues/1316))
Expand Down
16 changes: 16 additions & 0 deletions src/components/ResourceList/components/Item/Item.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,14 @@
margin: (-1 * resource-list-item(padding)) spacing(extra-tight)
(-1 * resource-list-item(padding)) resource-list-item(control-indent);
display: flex;

@include breakpoint-before(resource-list(breakpoint-small)) {
visibility: hidden;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

visibility: hidden; is required here to reserve the space in the dom so the item doesn't collapse and become partially hidden

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder what changed that this wasn't an issue before.


.selectMode & {
visibility: visible;
}
}
}

.selectable {
Expand Down Expand Up @@ -173,6 +181,10 @@
.focused & {
@include action-unhide;
}

@include page-content-when-partially-condensed {
display: none;
}
}

.persistActions {
Expand Down Expand Up @@ -202,6 +214,10 @@
min-height: resource-list-item(min-height);
pointer-events: initial;

.selectMode & {
display: none;
}

@include breakpoint-after(resource-list(breakpoint-small)) {
right: -1 * spacing(loose);
}
Expand Down