Skip to content

Conversation

yangchen1
Copy link
Contributor

@yangchen1 yangchen1 commented Apr 18, 2019

Should be shipped with https://github.com/Shopify/polaris-styleguide/pull/2714

WHY are these changes introduced?

Following up on Polaris day explorations on tertiary guidelines in modals

WHAT is this pull request doing?

After:
Best practices section:
image
Content section:
image

@BPScott BPScott temporarily deployed to polaris-react-pr-1336 April 18, 2019 19:09 Inactive
Copy link
Contributor

@selenehinkley selenehinkley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember seeing a slide deck with visual explorations. Are there screenshots available of do/don't examples we could add to the content section?

Copy link
Member

@BPScott BPScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No comments from me. Address Selene's requests then this is good to go.

@yangchen1
Copy link
Contributor Author

Thanks so much for the comments @selenehinkley ! Will address on Friday

@BPScott BPScott temporarily deployed to polaris-react-pr-1336 April 26, 2019 15:39 Inactive
@BPScott BPScott temporarily deployed to polaris-react-pr-1336 April 26, 2019 15:40 Inactive
@BPScott BPScott temporarily deployed to polaris-react-pr-1336 April 26, 2019 15:40 Inactive
@yangchen1 yangchen1 requested a review from selenehinkley April 26, 2019 16:09
@BPScott BPScott temporarily deployed to polaris-react-pr-1336 April 26, 2019 16:11 Inactive
@BPScott BPScott temporarily deployed to polaris-react-pr-1336 April 26, 2019 18:32 Inactive
@BPScott BPScott temporarily deployed to polaris-react-pr-1336 April 26, 2019 18:35 Inactive
@BPScott BPScott temporarily deployed to polaris-react-pr-1336 April 26, 2019 18:54 Inactive
@selenehinkley
Copy link
Contributor

I'm not sure why, but when I tophat the playground looks like this (and I can't see the added content):
Modal_-_Shopify_Polaris
Any idea's @BPScott? I'm following these instructions: https://github.com/Shopify/polaris-react/pull/1361/files

@selenehinkley
Copy link
Contributor

@jonniesweb helped me look into the issue and we think it has to do with one of the added images
polaris-styleguide_—_node_◂_node____dev_yarn_1_10_1_bin_yarn_js_run_dev_—_80×24

@yangchen1
Copy link
Contributor Author

@selenehinkley Those images are added in the styleguide repo in a separate branch/PR, I'm so sorry I forgot to cross link it here

https://github.com/Shopify/polaris-styleguide/pull/2714

@selenehinkley
Copy link
Contributor

Oh okay! So once that's merged then I 🎩 and it should show up, right?

@yangchen1
Copy link
Contributor Author

ok @selenehinkley I just merged the other one, so that error should go away now! So sorry for blocking that

@danrosenthal
Copy link

Hey @yangchen1, is this good to go?

@BPScott BPScott temporarily deployed to polaris-react-pr-1336 May 7, 2019 14:39 Inactive
@yangchen1
Copy link
Contributor Author

@BPScott Can you help with shipping this?

@danrosenthal
Copy link

Can you help with shipping this?

I've got you @yangchen1

@BPScott BPScott temporarily deployed to polaris-react-pr-1336 May 10, 2019 14:20 Inactive
@danrosenthal danrosenthal merged commit 6993d68 into master May 13, 2019
@danrosenthal danrosenthal deleted the tertiary-actions branch May 13, 2019 13:55
@yangchen1
Copy link
Contributor Author

Thank you @danrosenthal !!

@danrosenthal danrosenthal temporarily deployed to production May 13, 2019 18:17 Inactive
@amrocha amrocha deployed to testing-deploy-fix May 14, 2019 00:56 Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants