-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add tertiary action guideline to modal section #1336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember seeing a slide deck with visual explorations. Are there screenshots available of do/don't examples we could add to the content section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No comments from me. Address Selene's requests then this is good to go.
Thanks so much for the comments @selenehinkley ! Will address on Friday |
68f4996
to
4286035
Compare
I'm not sure why, but when I tophat the playground looks like this (and I can't see the added content): |
@jonniesweb helped me look into the issue and we think it has to do with one of the added images |
@selenehinkley Those images are added in the styleguide repo in a separate branch/PR, I'm so sorry I forgot to cross link it here |
Oh okay! So once that's merged then I 🎩 and it should show up, right? |
ok @selenehinkley I just merged the other one, so that error should go away now! So sorry for blocking that |
Hey @yangchen1, is this good to go? |
@BPScott Can you help with shipping this? |
I've got you @yangchen1 |
7bc04d1
to
5662dee
Compare
Thank you @danrosenthal !! |
Should be shipped with https://github.com/Shopify/polaris-styleguide/pull/2714
WHY are these changes introduced?
Following up on Polaris day explorations on tertiary guidelines in modals
WHAT is this pull request doing?
After:


Best practices section:
Content section: