[a11y] Made skeleton works in windows high contrast mode #1341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines. You can also join #polaris on the Shopify Partners Slack. |
dpersing
approved these changes
Apr 23, 2019
ry5n
reviewed
Apr 23, 2019
There was a problem hiding this comment.
This looks great :D
@mirualves One thing I forgot to mention earlier is we need to write an entry (in the UNRELEASED.md file) that goes into the changelog when we release the next version of Polaris React. I can help with that.
mirualves
force-pushed
the
low-vision-skeleton
branch
from
b2ea977 to
ec3060c
Compare
|
🎉 Thanks for your contribution to Polaris React! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes https://github.com/Shopify/polaris-ux/issues/234
WHAT is this pull request doing?
There wasn't a way to make it works for both normal and Microsoft high contrast, so we chose to use the Windows high contrast media query.
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
Run the playground locally or click the deployment link on this PR, and open one of the skeleton page examples.
You'll need to look this on Windows high contrast mode.
Talk to me if you need help :)
🎩 checklist