Skip to content

[a11y] Added an accessibility section to the text style component docs #1350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 24, 2019
Merged

[a11y] Added an accessibility section to the text style component docs #1350

merged 3 commits into from
Apr 24, 2019

Conversation

dpersing
Copy link

@dpersing dpersing commented Apr 24, 2019 •
edited
Loading

WHY are these changes introduced?

Adds accessibility guidance for the text style component, to appear in polaris-react docs and in the style guide.

See the draft Google doc for editing history for these changes and updates for other components and pages.

WHAT is this pull request doing?

  • Adds accessibility documentation for the text style component (web, iOS, and Android)
  • Adds an entry to UNRELEASED.md

How to 🎩

  1. Check out master from polaris-styleguide.
  2. In another Terminal tab or window, check out this branch from polaris-react and run the instructions for testing in a consuming project.
  3. In the polaris-styleguide tab, run dev up && dev start.
  4. View changes after examples and props: https://polaris.myshopify.io/components/titles-and-text/text-style (web, iOS, and Android)

Screenshots

Web

Screenshot of the web content view for the component docs

Android

Screenshot of the Android view for the component docs

iOS

Screenshot of the iOS view for the component docs

@BPScott BPScott temporarily deployed to polaris-react-pr-1350 April 24, 2019 20:05 Inactive
@dpersing dpersing mentioned this pull request Apr 24, 2019
Closed
sadiesaurus
sadiesaurus approved these changes Apr 24, 2019
View reviewed changes
Copy link
Contributor

@sadiesaurus sadiesaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks good!

@BPScott BPScott requested a deployment to polaris-react-pr-1350 April 24, 2019 21:36 Abandoned
@dpersing dpersing merged commit 6a8fda8 into master Apr 24, 2019
@dpersing dpersing deleted the text-style-a11y-docs branch April 24, 2019 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sadiesaurus sadiesaurus sadiesaurus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dpersing @sadiesaurus @BPScott