Skip to content

Conversation

dpersing
Copy link

@dpersing dpersing commented Apr 24, 2019

WHY are these changes introduced?

Adds accessibility information for the list and stack components, to appear in polaris-react docs and in the style guide.

See the draft Google doc for editing history for these changes and updates for other components and pages.

WHAT is this pull request doing?

  • Adds accessibility documentation for the list component (web, iOS, and Android)
  • Adds accessibility documentation for the stack component (web only)
  • Adds an entry to UNRELEASED.md

How to 🎩

  1. Check out master from polaris-styleguide.
  2. In another Terminal tab or window, check out this branch from polaris-react and run the instructions for testing in a consuming project.
  3. In the polaris-styleguide tab, run dev up && dev start.
  4. View changes after examples and props:

Screenshots

List

Screenshot of the list information for web

Stack

Screenshot of the stack information for web

Android

Screenshot of the Android view for the component docs

iOS

Screenshot of the iOS view for the component docs

@BPScott BPScott temporarily deployed to polaris-react-pr-1353 April 24, 2019 22:29 Inactive
@BPScott BPScott temporarily deployed to polaris-react-pr-1353 April 24, 2019 22:30 Inactive
Copy link
Contributor

@sadiesaurus sadiesaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks good! Just one minor suggestion.

Co-Authored-By: dpersing <devon.persing@shopify.com>
@BPScott BPScott temporarily deployed to polaris-react-pr-1353 April 25, 2019 15:46 Inactive
@dpersing dpersing merged commit 4703d52 into master Apr 25, 2019
@dpersing dpersing deleted the list-stack-a11y-docs branch April 25, 2019 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants