[Loading] Add colour for high contrast mode #1389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpersing
approved these changes
May 1, 2019
There was a problem hiding this comment.
This looks great. Thanks so much for tackling this issue @ruairiphackett! I updated UNRELEASED.md so you should be good to squash and merge when tests are done rerunning.
ghost
added
the
cla-needed
ghost
removed
the
cla-needed
|
🎉 Thanks for your contribution to Polaris React! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #776
WHAT is this pull request doing?
Adding a colour to the
Loadinglevel so the component is visible in Windows high contrast mode.Before:
After:
🎩 checklist
README.mdwith documentation changescc @dpersing