[Breakpoints] fix breakpoint off by 1 #1475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danrosenthal
added
the
🤖Skip Changelog
|
cc: @keyfer @asmockler 🤦♂ |
|
I think this is actually wrong. Hang tight |
danrosenthal
changed the title
danrosenthal
force-pushed
the
fix-sheet-responsive
branch
from
aba39aa to
1fc0951
Compare
|
The JavaScript is actually what needed to be changed here. This has been broken for a long time and we just weren't noticing. |
danrosenthal
removed
the
🤖Skip Changelog
danrosenthal
force-pushed
the
fix-sheet-responsive
branch
from
1fc0951 to
ae3ba18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While tophatting a change in web to replace the web implementation of
Sheetwith the Polaris implementation, I saw that the breakpoint in the JavaScript is wrong, as navigation should be displayed inclusive of 768px, but not 769px. This results in a sheet which, for one pixel at769pxwide appears as the desktop sheet but functions as the mobile sheet (closing towards the bottom). This fixes that issue.