[v4][FileUpload] Remove withContext/withRef #1491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewMusgrave
force-pushed
the
fu-dep-hoc
branch
from
a2616cc to
83981b9
Compare
AndrewMusgrave
added
the
🤖Skip Changelog
AndrewMusgrave
commented
May 15, 2019
| import DropZoneContext from '../../context'; | ||
| import {usePolaris} from '../../../../hooks'; | ||
|
|
||
| export interface State { |
There was a problem hiding this comment.
We have no need for state. See below 👀
AndrewMusgrave
commented
May 15, 2019
| const {size, type} = React.useContext(DropZoneContext); | ||
| const suffix = capitalize(type); | ||
| const { | ||
| actionTitle = translate(`Polaris.DropZone.FileUpload.actionTitle${suffix}`), |
There was a problem hiding this comment.
We use the provided actionTitle/Hint and default it to what was previously the default on state
There was a problem hiding this comment.
I wonder why we had done that?
There was a problem hiding this comment.
Seems like it was to avoid string translation however object lookup is inexpensive so I'm not sure why, or this approach didn't occur when developing the component? 🤷♂
dleroux
approved these changes
May 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Part of #1484
WHAT is this pull request doing?
I'm converting FileUpload to a functional component and removing
withRef/withContextHow to 🎩
Tests / percy / development server