[v4][Navigation.Item] Remove withContext #1502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewMusgrave
force-pushed
the
ni-dep-hoc
branch
from
401a7f5 to
131d796
Compare
AndrewMusgrave
force-pushed
the
ni-dep-hoc
branch
from
131d796 to
2680c2b
Compare
AndrewMusgrave
added
the
🤖Skip Changelog
AndrewMusgrave
commented
May 15, 2019
AndrewMusgrave
force-pushed
the
ni-dep-hoc
branch
from
2680c2b to
8b306b5
Compare
AndrewMusgrave
force-pushed
the
ni-dep-hoc
branch
from
8b306b5 to
a7cc8a3
Compare
alex-page
approved these changes
May 28, 2019
There was a problem hiding this comment.
There are some warnings from deprecation, not sure if that should be happening:
warn: ["Deprecation: <Navigation.UserMenu /> is deprecated and will be removed in the next major version. Use <TopBar.UserMenu /> instead."]
warn: ["Deprecation: the `userMenu` prop is deprecated and will be removed in the next major version. Pass a user menu into <TopBar /> instead."]The functionality is working in chrome. Nice work @AndrewMusgrave
AndrewMusgrave
force-pushed
the
ni-dep-hoc
branch
from
a7cc8a3 to
f7251e2
Compare
It's all good, they haven't been removed yet 😄 |
BPScott
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Part of #1484
WHAT is this pull request doing?
I'm converting Navigation.Item to a functional component and removing
withContextHow to 🎩
Tests / percy / development server