Skip to content

[v4] Remove prop types #1505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 16, 2019
Merged

[v4] Remove prop types #1505

merged 2 commits into from
May 16, 2019

Conversation

AndrewMusgrave
Copy link
Member

@AndrewMusgrave AndrewMusgrave commented May 15, 2019 •
edited
Loading

WHY are these changes introduced?

Resolves #1504

We removed all of the old context 😄

@AndrewMusgrave AndrewMusgrave added the 🤖Skip Changelog Causes CI to ignore changelog update check. label May 15, 2019
@AndrewMusgrave AndrewMusgrave requested a review from BPScott May 15, 2019 22:52
BPScott
BPScott approved these changes May 16, 2019
View reviewed changes
Copy link
Member

@BPScott BPScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yesssss! So happy that we can do this! 🔥 🔥 🔥

Also goodbye to that smell where types.ts files contained runtime JS code

@AndrewMusgrave AndrewMusgrave merged commit e90362f into version-4.0.0 May 16, 2019
@AndrewMusgrave AndrewMusgrave deleted the remove-prop-types branch May 16, 2019 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BPScott BPScott BPScott approved these changes

Assignees

No one assigned

Labels

🤖Skip Changelog Causes CI to ignore changelog update check.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AndrewMusgrave @BPScott