Skip to content

[v4] Simplify withinContentContext #1602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 5, 2019
Merged

[v4] Simplify withinContentContext #1602

merged 2 commits into from
Jun 5, 2019

Conversation

AndrewMusgrave
Copy link
Member

@AndrewMusgrave AndrewMusgrave commented May 30, 2019 •
edited
Loading

WHY are these changes introduced?

Fixes #1521

WHAT is this pull request doing?

Changing WithinContentContextType from {withinContentContext: boolean} to boolean

@BPScott BPScott temporarily deployed to polaris-react-pr-1602 May 30, 2019 14:41 Inactive
@BPScott BPScott temporarily deployed to polaris-react-pr-1602 May 30, 2019 14:47 Inactive
@AndrewMusgrave AndrewMusgrave force-pushed the simplify-withincontentcontext branch from 9c02a0c to d69e8a9 Compare May 30, 2019 14:55
@BPScott BPScott temporarily deployed to polaris-react-pr-1602 May 30, 2019 14:55 Inactive
@AndrewMusgrave AndrewMusgrave added the 🤖Skip Changelog Causes CI to ignore changelog update check. label May 30, 2019
@AndrewMusgrave AndrewMusgrave self-assigned this May 30, 2019
@AndrewMusgrave AndrewMusgrave marked this pull request as ready for review May 30, 2019 15:06
@AndrewMusgrave AndrewMusgrave requested a review from BPScott May 30, 2019 15:06
BPScott
BPScott approved these changes May 30, 2019
View reviewed changes
Copy link
Member

@BPScott BPScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think defining that WithinContentContextType is actually valuable, it just seems to add noise. What do you think to removing it?

If you don't fancy it then this is good to go. 👍

src/components/WithinContentContext/context.tsx Outdated
export interface WithinContentContextType {
withinContentContainer: boolean;
}
export type WithinContentContextType = boolean;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having to define and export such a trivial type just so we can use it in tests feels a bit rubbish.

What do you think to removing this and updating the tests so the TestComponent is const TestComponent = (_: any) => null;?

@AndrewMusgrave AndrewMusgrave force-pushed the simplify-withincontentcontext branch from d69e8a9 to 61c638d Compare June 5, 2019 15:32
@AndrewMusgrave AndrewMusgrave force-pushed the simplify-withincontentcontext branch from 61c638d to 2b22627 Compare June 5, 2019 16:20
@BPScott BPScott requested a deployment to polaris-react-pr-1602 June 5, 2019 16:20 Abandoned
@AndrewMusgrave AndrewMusgrave merged commit 6294dc4 into version-4.0.0 Jun 5, 2019
@AndrewMusgrave AndrewMusgrave deleted the simplify-withincontentcontext branch June 5, 2019 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BPScott BPScott BPScott approved these changes

Assignees

@AndrewMusgrave AndrewMusgrave

Labels

🤖Skip Changelog Causes CI to ignore changelog update check.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AndrewMusgrave @BPScott