Skip to content

Conversation

dpersing
Copy link

@dpersing dpersing commented Jun 5, 2019

WHY are these changes introduced?

Adds accessibility guidance for the exception list component, to appear in polaris-react docs and in the style guide.

WHAT is this pull request doing?

  • Adds accessibility information to the component README.md
  • Adds an entry to the documentation section of UNRELEASED.md

How to 🎩

  1. Check out master from polaris-styleguide
  2. In another Terminal tab or window, check out this branch from polaris-react and run the instructions for testing in a consuming project
  3. In the polaris-styleguide tab, run dev up && dev start
  4. View changes after examples and props: https://polaris.myshopify.io/components/lists-and-tables/exception-list (web only)

Screenshots

Web

Screenshot of the content changes

@dpersing dpersing requested a review from sadiesaurus June 5, 2019 22:37
@dpersing dpersing self-assigned this Jun 5, 2019
@BPScott BPScott temporarily deployed to polaris-react-pr-1635 June 5, 2019 22:38 Inactive
@BPScott BPScott temporarily deployed to polaris-react-pr-1635 June 5, 2019 22:41 Inactive
Copy link
Contributor

@sadiesaurus sadiesaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny comment

Co-Authored-By: Sadie Redden <sadie.redden@shopify.com>
@BPScott BPScott temporarily deployed to polaris-react-pr-1635 June 6, 2019 20:47 Inactive
@dpersing dpersing merged commit aa99cbb into master Jun 6, 2019
@dpersing dpersing deleted the exceptionlist-a11y-docs branch June 6, 2019 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants