[v4] Removed all usage of findDOMNode #1696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewMusgrave
force-pushed
the
remove-finddomnode
branch
from
48213e2 to
9576cf3
Compare
AndrewMusgrave
commented
Jun 18, 2019
| bulkActionButtonNode.getBoundingClientRect().width) || | ||
| 0; | ||
| const width = (this.bulkActionButton | ||
| .current as HTMLButtonElement).getBoundingClientRect().width; |
There was a problem hiding this comment.
This cast is to increase codecov. We don't optionally render the button so this ref will always exist in componentDidMount lifecycle
AndrewMusgrave
commented
Jun 18, 2019
| }); | ||
| }); | ||
|
|
||
| function FocusTestWrapper({children, ...props}: Discard<Props, 'root'>) { |
There was a problem hiding this comment.
Wrapper component that passes a root to Focus
AndrewMusgrave
force-pushed
the
remove-finddomnode
branch
from
cf9f4a2 to
9f979a6
Compare
AndrewMusgrave
changed the title
AndrewMusgrave
added
the
🤖Skip Changelog
dleroux
approved these changes
Jun 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Last change before we can enable strict mode 🎉
WHAT is this pull request doing?
Luckily none of our uses require findDOMNode to find a child element without any context so we can replace them with refs.