-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Filters component #1718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filters component #1718
Conversation
😍 |
src/components/ResourceFilters/components/ConnectedFilterControl/ConnectedFilterControl.tsx
Show resolved
Hide resolved
eabdeea
to
65cfccc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍
I went ahead an updated the component to be called |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 💖 A few comments and questions.
I didn't see the related components section. Did we decide it was best to not include it here?
Yes, the format for related components is to suggest other components if trying to do something related, but we have no other filter component so it didn’t feel right to include. |
12ec72b
to
eba0209
Compare
Okay going to merge! If there are any other changes to docs we can do them in follow-up PRs. |
WHY are these changes introduced?
Closes #1167
Closes #1510
WHAT is this pull request doing?
Moving the
<Filters />
component to PolarisDocumentation
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
Copy-paste this code in
playground/Playground.tsx
:🎩 checklist
README.md
with documentation changesKnown issues
@danrosenthal did some digging and looks like any children which cause a reflow (here is all of the things that can cause a reflow) during the entering animation will force the animation to skip to the end. For more details see reactjs/react-transition-group#382. For now this is a won’t fix.
Related todos
The following will be done in other PRs:
ResourceList.Item
to its own component namedResourceItem
ResourceList
examples to useResourceFilters
FilterControl