Skip to content

Rename yarn script ts to type-check #1745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2019
Merged

Rename yarn script ts to type-check #1745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ We’ll review your pull request and either merge it, request changes to it, or
1. If your pull request modifies any SVG files run `yarn optimize`
1. Format your code with `yarn format`
1. Make sure your code lints with `yarn lint`
1. Run the TypeScript compiler with `yarn ts`
1. Run the TypeScript compiler with `yarn type-check`
1. [Tophat 🎩](https://github.com/Shopify/polaris-react/blob/master/documentation/Tophatting.md) your changes locally with `yarn dev`
1. If you haven’t already, [sign a CLA](https://cla.shopify.com/)

Expand Down
2 changes: 2 additions & 0 deletions UNRELEASED.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ Use [the changelog guidelines](https://git.io/polaris-changelog-guidelines) to f

### Development workflow

- Renamed `yarn run ts` to `yarn run type-check` to match most other Shopify projects

### Dependency upgrades

### Code quality
Expand Down
2 changes: 1 addition & 1 deletion dev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,4 @@ commands:
server: yarn run dev
style: yarn run lint
test: yarn run test
type-check: yarn run ts
type-check: yarn run type-check
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,12 @@
"scripts": {
"lint": "sewing-kit lint",
"format": "sewing-kit format",
"ts": "tsc --noEmit",
"type-check": "sewing-kit type-check",
Copy link
Member

@AndrewMusgrave AndrewMusgrave Jun 26, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does sewing-kit run under the hood?

Edit: just checked 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It still runs tsc --noEmit under the hood

"test": "sewing-kit test",
"test:coverage": "yarn test --coverage",
"test:ci": "yarn test --coverage",
"check": "npm-run-all lint ts test",
"check:ci": "npm-run-all lint ts test:ci",
"check": "npm-run-all lint type-check test",
"check:ci": "npm-run-all lint type-check test:ci",
"clean": "rimraf build esnext styles types docs \"build-intermediate\" \"index.*\" \"./src/styles/polaris-tokens\" \"styles.{css,scss}\"",
"clean:build": "rimraf \"build/!(cache|coverage|storybook)\" esnext styles types docs \"build-intermediate\" \"index.*\" \"./src/styles/polaris-tokens\" \"styles.{css,scss}\"",
"optimize": "sewing-kit optimize",
Expand Down