[ToastManager] Move aria-live to containing div for a11y using NVDA #1873
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #1215
WHAT is this pull request doing?
In order to announce the Toast using the aria-live attribut, NVDA require the element with the aria-live prop to be on screen when the content changes.
Our Toasts are wrapped in a Toast manager. This pr moves the aria-live attribute from the Toast to the Toast Manager
How to 🎩
Using NVDA (on windows) navigate to:
http://localhost:6006/?path=/story/all-components-toast--basic-toast
and ensure that the Toast messages are being announced.
Copy-paste this code in
playground/Playground.tsx
:🎩 checklist
README.md
with documentation changes