[Link, Plain button] Add underline to Links and Plain button on hover #1885
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes https://github.com/Shopify/polaris-ux/issues/147
The current hover/focus styles rely on a change in color alone which isn't visible in Windows High Contrast, and may be difficult for other low vision users to distinguish. An underline that's displayed when a user starts to interact with the link would help cement the idea that it's a link and clarify exactly what that particular link does.
WHAT is this pull request doing?
Add underline to Links and Plain button on hover, so it doesn't rely on color alone for accessibility.
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
Copy-paste this code in
playground/Playground.tsx
:🎩 checklist
README.md
with documentation changes