Skip to content

Update examples to v4 & add ts-react-testing example #1937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 8, 2019
Merged

Update examples to v4 & add ts-react-testing example #1937

merged 2 commits into from
Aug 8, 2019

Conversation

AndrewMusgrave
Copy link
Member

@AndrewMusgrave AndrewMusgrave commented Aug 7, 2019 •
edited
Loading

WHAT is this pull request doing?

  • Updating examples to v4.0.0-rc.2
  • Adding a new example create-react-app-ts-react-testing to align more with our current stack since we're all about promoting typescript (other create-react-app example is enzyme)
  • Remove linting from examples since examples are independently run. It doesn't make sense to have linting and ignores that won't apply to the specific examples

How to 🎩

Startup the examples and look for errors and see if they work 🔍

@BPScott BPScott temporarily deployed to polaris-react-pr-1937 August 7, 2019 17:18 Inactive
@BPScott BPScott temporarily deployed to polaris-react-pr-1937 August 7, 2019 17:21 Inactive
@AndrewMusgrave AndrewMusgrave changed the title Updated examples & added typescript react-testing example Update examples to v4 & add ts-react-testing example Aug 7, 2019
@BPScott BPScott temporarily deployed to polaris-react-pr-1937 August 7, 2019 17:29 Inactive
AndrewMusgrave
AndrewMusgrave commented Aug 7, 2019
View reviewed changes
.eslintignore
@@ -1,5 +1,5 @@
node_modules
/examples/*/build
/examples
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our examples are to be run independently, we shouldn't link based on our repo's rules.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@BPScott BPScott temporarily deployed to polaris-react-pr-1937 August 7, 2019 17:45 Inactive
@BPScott BPScott temporarily deployed to polaris-react-pr-1937 August 7, 2019 17:48 Inactive
@AndrewMusgrave AndrewMusgrave marked this pull request as ready for review August 7, 2019 17:48
chloerice
chloerice approved these changes Aug 8, 2019
View reviewed changes
Copy link
Member

@chloerice chloerice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All updated examples work! Not related to these changes, but the browserify example seems like it's missing files 🤔 Should it only have a build folder?

@AndrewMusgrave
Copy link
Member Author

All updated examples work! Not related to these changes, but the browserify example seems like it's missing files 🤔 Should it only have a build folder?

@chloerice Ben deleted the browserify example, you should be 👌 to delete the build folder 😄

@BPScott BPScott requested a deployment to polaris-react-pr-1937 August 8, 2019 20:16 Abandoned
@AndrewMusgrave AndrewMusgrave merged commit 02b0246 into master Aug 8, 2019
@AndrewMusgrave AndrewMusgrave deleted the update-examples-v4 branch August 8, 2019 20:22
@AndrewMusgrave AndrewMusgrave temporarily deployed to production August 13, 2019 21:12 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chloerice chloerice chloerice approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AndrewMusgrave @chloerice @BPScott