Add minified styles to npm package #1957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for using unpkg as a CDN source
|
Skipping the changelog on this PR, I'll write a changelog entry in the follow up PR that talks about changing URLs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Maintaining our own CDN distribution of our CSS files is a little annoying as it leads to more complex builds. Let's let unpkg handle our CDN styles.
The first step to that is adding minified styles into npm package - that's this PR.
The second step is ripping out our build config that uploads files to sdks.shopifycdn.com and updates our links to unpkg.com files (that'll be a new PR after we do an RC containing this change)
WHAT is this pull request doing?
Adds
styles.min.cssto our npm packageHow to 🎩
yarn run buildand see thatstyles.min.cssis generatednpm packthen extract the generated tgz and see that styles.min.css is included in the package folderstyles.min.cssis excluded from git and linting configsyarn run cleandeletesstyles.min.css