Skip to content

[Modal] Fixed animation issue present in async Modal rendering #2076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2019
Merged

[Modal] Fixed animation issue present in async Modal rendering #2076

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions UNRELEASED.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ Use [the changelog guidelines](https://git.io/polaris-changelog-guidelines) to f

### Bug fixes

- Fixed animation for Modal when being rendered asynchronously ([#2076](https://github.com/Shopify/polaris-react/pull/2076))
Copy link
Contributor

@loic-d loic-d Sep 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably just say 'when being mounted with open:true directly' or something like that?
Rendering the modal asynchronously using react-async is one of the scenario where it's mounted directly with open:true but there are others.

Copy link
Contributor Author

@mitchmaps mitchmaps Sep 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks!


### Documentation

### Development workflow
Expand Down
2 changes: 2 additions & 0 deletions src/components/Modal/components/Dialog/Dialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,8 @@ export function Dialog({
}

const fadeUpClasses = {
appear: classNames(styles.animateFadeUp, styles.entering),
appearActive: classNames(styles.animateFadeUp, styles.entered),
Copy link
Contributor

@loic-d loic-d Sep 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

enter: classNames(styles.animateFadeUp, styles.entering),
enterActive: classNames(styles.animateFadeUp, styles.entered),
exit: classNames(styles.animateFadeUp, styles.exiting),
Expand Down