Skip to content

[Search] Adjust overlay max-height and max-width #2103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2019
Merged

[Search] Adjust overlay max-height and max-width #2103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43059ca
[Search] Adjust overlay max-height and max-width
joshuajay Sep 9, 2019
1e7c1f6
Merge branch 'master' into search-overlay-adjustment
joshuajay Sep 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions UNRELEASED.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ Use [the changelog guidelines](https://git.io/polaris-changelog-guidelines) to f

### Enhancements

- Adjusted search results overlay to take up 100% height of the screen on small screens and to match the width of the search bar on large screens. ([#2103](https://github.com/Shopify/polaris-react/pull/2103))
- Added skipToContentTarget prop to Frame component ([#2080](https://github.com/Shopify/polaris-react/pull/2080))

### Bug fixes
Expand Down
2 changes: 2 additions & 0 deletions src/components/TopBar/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ $stacking-order: (
search: 20,
);

$search-max-width: rem(694px);

// TODO: Replace `$large-width` breakpoints with
// `page-content-when-not-partially-condensed`
// Once the frame is rendering our React routes
Expand Down
5 changes: 2 additions & 3 deletions src/components/TopBar/components/Search/Search.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
@import '../../variables';

$page-layout-when-not-partially-condensed-absolute: rem(743px);
$search-results-max-width: 70rem;
$search-results-min-width: 45rem;

.Search {
Expand All @@ -11,7 +10,7 @@ $search-results-min-width: 45rem;
left: 0;
right: 0;
top: top-bar-height();
height: calc(100vh - #{top-bar-height() + spacing(loose)});
height: calc(100vh - #{top-bar-height()});
visibility: hidden;
pointer-events: none;
padding: 0;
Expand All @@ -37,7 +36,7 @@ $search-results-min-width: 45rem;
flex-direction: column;
align-items: stretch;
width: 100%;
max-width: $search-results-max-width;
max-width: $search-max-width;
min-width: $search-results-min-width;
max-height: 100%;

Expand Down
2 changes: 1 addition & 1 deletion src/components/TopBar/components/SearchField/SearchField.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ $stacking-order: (
align-items: center;
border: 1px solid transparent;
width: 100%;
max-width: rem(694px);
max-width: $search-max-width;
}

// We have both a focused class and a focus pseudo selector here
Expand Down