Skip to content

Conversation

@AndrewMusgrave
Copy link
Member

WHY are these changes introduced?

Convert examples to hooks

WHAT is this pull request doing?

Converting ResourceList, ResourcePicker, and Select class-based examples to hooks

STILL TO DO

I'm making quite a few pr's converting examples to hooks so I anticipate lots of unreleased.md conflicts, so I'll add the entry before I merge.

- Converted `ResourceList`, `ResourcePicker`, and `Select` examples to functional components ([#2133](https://github.com/Shopify/polaris-react/pull/2133))

How to 🎩

Make sure the behavior of the example mirrors the style guide

🎩 checklist

Copy link
Contributor

@dleroux dleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Wondering if we should be updating changelog for these changes because we do use these examples in the style guide and it would help track issues if any.

@AndrewMusgrave AndrewMusgrave merged commit c598e14 into master Sep 16, 2019
@AndrewMusgrave AndrewMusgrave deleted the hookify-examples-8 branch September 16, 2019 18:20
@dleroux dleroux temporarily deployed to production September 20, 2019 17:44 Inactive
@dleroux dleroux temporarily deployed to production September 23, 2019 15:28 Inactive
@dleroux dleroux temporarily deployed to production September 23, 2019 15:38 Inactive
@dleroux dleroux temporarily deployed to production September 23, 2019 16:59 Inactive
@dleroux dleroux temporarily deployed to production September 23, 2019 17:05 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants