Skip to content

Conversation

@dfmcphee
Copy link
Contributor

@dfmcphee dfmcphee commented Oct 3, 2019

WHY are these changes introduced?

Fixes #2226

This fixes fullWidth Card.Sections not appearing full width when a Nav is present.

WHAT is this pull request doing?

This adds a padding override inside the page breakpoint as well as fixing the default padding.

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

Add a Card with a fullWidth Card.Section to a page that also has a Frame and a Nav

🎩 checklist

@dfmcphee dfmcphee requested a review from dleroux October 3, 2019 14:34
@dfmcphee dfmcphee requested a review from chloerice October 3, 2019 14:36
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2019

Results

💦 Potential splash zone of changes introduced to src/**/*.tsx in this pull request:

Files modified2
Files potentially affected4

Details

All files potentially affected (total: 4)
UNRELEASED.md (total: 0)

Files potentially affected (total: 0)

🎨 src/components/Card/Card.scss (total: 4)

Files potentially affected (total: 4)


This comment automatically updates as changes are made to this pull request.
Feedback, troubleshooting: open an issue or reach out on Slack in #polaris-tooling.

Copy link
Contributor

@dleroux dleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dfmcphee dfmcphee merged commit d468a1a into master Oct 3, 2019
@dfmcphee dfmcphee deleted the fix-full-width-section branch October 3, 2019 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Card sections with fullWidth option not displayed full width when Nav present

2 participants