Skip to content

Conversation

@arapehl
Copy link
Contributor

@arapehl arapehl commented Oct 3, 2019

WHY are these changes introduced?

Fixes: #1677
Fixes: https://github.com/Shopify/online-store-web/issues/4667

WHAT is this pull request doing?

Causes <Tabs /> component to collapse correctly on small screens in pre-iOS 13 versions of Safari. The screenshots go back to iOS 11 but it fixes the issue all the way back to iOS 9. (The tabs don't render properly in iOS 8.)

Before After
Screen Shot 2019-10-03 at 1 55 28 PM Screen Shot 2019-10-03 at 1 55 47 PM
Screen Shot 2019-10-03 at 1 56 30 PM Screen Shot 2019-10-03 at 1 56 46 PM
Screen Shot 2019-10-03 at 1 58 28 PM Screen Shot 2019-10-03 at 2 06 17 PM

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

Copy-paste this code in playground/Playground.tsx:
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}

🎩 checklist

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2019

Results

💦 Potential splash zone of changes introduced to src/**/*.tsx in this pull request:

Files modified2
Files potentially affected1

Details

All files potentially affected (total: 1)
UNRELEASED.md (total: 0)

Files potentially affected (total: 0)

🎨 src/components/Tabs/Tabs.scss (total: 1)

Files potentially affected (total: 1)


This comment automatically updates as changes are made to this pull request.
Feedback, troubleshooting: open an issue or reach out on Slack in #polaris-tooling.

@arapehl arapehl requested review from alex-page, beefchimi and danrosenthal and removed request for alex-page October 3, 2019 18:17
@arapehl arapehl requested a review from beefchimi October 4, 2019 17:34
Copy link
Contributor

@beefchimi beefchimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎩 🚢

@beefchimi beefchimi added the Bug Something is broken and not working as intended in the system. label Oct 4, 2019
Copy link
Contributor

@dleroux dleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@arapehl arapehl merged commit a575c0c into master Oct 4, 2019
@arapehl arapehl deleted the fix-tabs-in-ios branch October 4, 2019 19:42
@dleroux dleroux temporarily deployed to production October 8, 2019 11:46 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something is broken and not working as intended in the system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tabs do not collapse when using safari on iPhone

4 participants