Skip to content

Theme provider cleanup #2234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2019
Merged

Theme provider cleanup #2234

merged 1 commit into from
Oct 3, 2019

Conversation

@danrosenthal
Copy link

@danrosenthal danrosenthal commented Oct 3, 2019

No description provided.

@danrosenthal danrosenthal force-pushed the theme-provider-cleanup branch from f510018 to d2a3cfe Compare October 3, 2019 19:06
@danrosenthal
Copy link
Author

danrosenthal commented Oct 3, 2019

Approved here: #2225

I goofed and didn't merge that PR into master.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2019 •
edited
Loading

Results

💦 Potential splash zone of changes introduced to src/**/*.tsx in this pull request:

Files modified13
Files potentially affected33

Details

All files potentially affected (total: 33)
❔ UNRELEASED.md (total: 0)

Files potentially affected (total: 0)

🧩 src/components/AppProvider/AppProvider.tsx (total: 0)

Files potentially affected (total: 0)

🧩 src/components/PolarisTestProvider/PolarisTestProvider.tsx (total: 0)

Files potentially affected (total: 0)

🧩 src/components/ThemeProvider/ThemeProvider.tsx (total: 1)

Files potentially affected (total: 1)

🧩 src/components/ThemeProvider/tests/ThemeProvider.test.tsx (total: 0)

Files potentially affected (total: 0)

🧩 src/utilities/color-manipulation.ts (total: 29)

Files potentially affected (total: 29)

🧩 src/utilities/color-transformers.ts (total: 31)

Files potentially affected (total: 31)

🧩 src/utilities/tests/color-manipulation.test.ts (total: 0)

Files potentially affected (total: 0)

🧩 src/utilities/tests/color-transformers.test.ts (total: 0)

Files potentially affected (total: 0)

🧩 src/utilities/theme/index.ts (total: 27)

Files potentially affected (total: 27)

🧩 src/utilities/theme/tests/utils.test.ts (total: 0)

Files potentially affected (total: 0)

🧩 src/utilities/theme/types.ts (total: 31)

Files potentially affected (total: 31)

🧩 src/utilities/theme/utils.ts (total: 28)

Files potentially affected (total: 28)

This comment automatically updates as changes are made to this pull request.
Feedback, troubleshooting: open an issue or reach out on Slack in #polaris-tooling.

@danrosenthal danrosenthal force-pushed the theme-provider-cleanup branch 2 times, most recently from 5b43a4b to d178fd3 Compare October 3, 2019 19:13
@danrosenthal @BPScott @tmlayton
clean up theme provider in preparation for color system work
bd60626 
Co-authored-by: Tim Layton <tim.layton@shopify.com>
Co-authored-by: Ben Scott <ben.scott@shopify.com>
Co-authored-by: Tim Layton <tmlayton@users.noreply.github.com>
@danrosenthal danrosenthal force-pushed the theme-provider-cleanup branch from d178fd3 to bd60626 Compare October 3, 2019 19:19
@danrosenthal danrosenthal merged commit 6c8e3ff into master Oct 3, 2019
@danrosenthal danrosenthal deleted the theme-provider-cleanup branch October 3, 2019 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@danrosenthal